fix: ordering of Callback accounts

[taco-paco]

Summary by CodeRabbit

• Chores

  • Updated internal import organization and code formatting.
  • Added documentation comments for leaderboard account structures.

• Refactor

  • Modified leaderboard update mechanism to include an additional account parameter for enhanced security handling.

[coderabbitai]

Walkthrough

This PR modifies the UpdateLeaderboard accounts struct in the Solana program by introducing a new escrow_auth account field alongside the existing escrow field. The change also includes import additions and minor formatting adjustments.

Changes

Cohort / File(s)	Summary
Account Structure Update and Import Adjustments magic-actions/programs/magic-actions/src/lib.rs	Added anchor_lang::Discriminator import and reordered ephemeral imports. Updated UpdateLeaderboard struct to include separate escrow_auth and escrow account fields with documentation. Applied minor formatting and whitespace refinements throughout.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Primary consideration: Verify the new escrow_auth field integrates correctly with existing account handling logic and transaction processing
• Import changes: Straightforward mechanical reordering and addition
• Struct field addition: Ensure the second escrow account field aligns with intended program semantics and doesn't introduce validation gaps

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately describes the main change: reordering of accounts in the UpdateLeaderboard struct, specifically adding escrow_auth before escrow.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/magic-actions/ordering

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

magic-actions/programs/magic-actions/src/lib.rs (1)

136-149: Critical: Test account ordering does not match updated struct definition.

The Rust struct UpdateLeaderboard (lines 136-149) expects accounts in this order: counter, escrow_auth, escrow. However, the test at magic-actions/tests/magic-actions.ts:52-55 provides them in the wrong order: counter, escrow, escrowAuth.

Fix the test to match the new struct ordering:

.accounts({
  counter: pda,
  escrowAuth: pda,
  escrow: pda,
})

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 48b1b7f and 36d9b5a.

📒 Files selected for processing (1)

• magic-actions/programs/magic-actions/src/lib.rs (8 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

magic-actions/programs/magic-actions/src/lib.rs (1)

anchor-counter/programs/anchor-counter/src/lib.rs (1)

• commit (50-58)

🔇 Additional comments (3)

magic-actions/programs/magic-actions/src/lib.rs (3)

41-50: LGTM - Formatting improvements.

The added whitespace and multi-line formatting of the msg! macro improve readability without changing functionality.

---

75-115: LGTM - Minor formatting adjustments.

The whitespace additions and line break adjustments improve code organization without affecting behavior.

---

84-101: Verify CallHandler accounts list is complete.

The accounts vector in CallHandler includes only leaderboard and counter, but the UpdateLeaderboard struct now requires four accounts: leaderboard, counter, escrow_auth, and escrow.

Based on the documentation comments indicating these accounts "will be moved to the end in the future, meaning you can omit this unless needed," it appears the Magic framework automatically appends the escrow accounts during callback execution. However, please confirm this is the correct behavior and that the framework properly derives and validates these accounts.

Consider adding a code comment here explaining that the Magic framework automatically provides the escrow accounts, for clarity.

[coderabbitai]

🧹 Nitpick | 🔵 Trivial

🧩 Analysis chain

Verify if the Discriminator import is needed.

The Discriminator trait is imported but doesn't appear to be used explicitly in the code. If it's not required by the macros or used elsewhere, consider removing it to keep imports clean.

Run the following script to check if Discriminator is actually used:

---

🏁 Script executed:

#!/bin/bash
# Check if Discriminator is used anywhere in the file
rg -n 'Discriminator' magic-actions/programs/magic-actions/src/lib.rs

Length of output: 33

---

Remove the unused Discriminator import on line 2.

The Discriminator trait is imported from anchor_lang but is never used anywhere in the file. This is dead code that should be cleaned up.

🤖 Prompt for AI Agents

In magic-actions/programs/magic-actions/src/lib.rs around line 2, the file
imports the unused trait `Discriminator` from `anchor_lang`; remove the dead
import line `use anchor_lang::Discriminator;` so the file no longer contains an
unused import and rebuild to ensure no other references exist.