Skip to content

Conversation

@sahas3
Copy link
Member

@sahas3 sahas3 commented Nov 3, 2025

Releasing the wheels has been failing for a month now https://github.com/llvm/torch-mlir-release/actions/runs/19032410905/job/54349329471#step:7:30 due to the GH limit that each release artifact can only have a maximum of 1000 artifacts (some discussion captured here https://github.com/orgs/community/discussions/165616).

This PR has two changes:

  1. I have added a CI that will remove assets older than 60 days -- we release 4 assets daily (3 for linux + 1 for windows). So technically this can be increased to 250 days but I don't know if there is a need to keep assets that old. I have chosen 60 days since I recall seeing somewhere that's how long PyTorch keep their nightly releases but I couldn't find that now.

An alternative to keeping all the assets will probably be to release the assets with new name daily but seems overkill to me. Open to other suggestions as well.

  1. Added the artifactErrorsFailBuild flag on the release CIs which I think will cause the builds to fail if the upload step fails -- currently the build doesn't fail which is why I think we didn't notice this earlier.

@sahas3
Copy link
Member Author

sahas3 commented Nov 3, 2025

Hi @marbre, @stellaraccident, @saienduri, @sjain-stanford can you take a look please? Don't have write permissions in this repo, so just tagging you all. Thanks!

@marbre
Copy link
Member

marbre commented Nov 3, 2025

Hi @marbre, @stellaraccident, @saienduri, @sjain-stanford can you take a look please? Don't have write permissions in this repo, so just tagging you all. Thanks!

I was made aware of this issue during the LLVM dev mtg but didn't had a chance to yank old releases as I was still traveling. Hoping to find a bit more time soon.

@rolfmorel
Copy link

rolfmorel commented Nov 5, 2025

As another user/stakeholder of the python packages -- thank you, @sahas3!

Upon discussion with @marbre and @banach-space, we also figured the 1000 files limit is the current issue. The changes you propose seem right on the money to me 👍

Copy link

@banach-space banach-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG % minor comments/suggestions

Thanks for implementing this!

Copy link

@banach-space banach-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG % minor comments/suggestions

Thanks for implementing this!

@sahas3 sahas3 force-pushed the deleteOldReleases branch from 51890ea to 5d1fa67 Compare November 6, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants