-
Notifications
You must be signed in to change notification settings - Fork 7
Delete old releases #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…CI build fix is valid." This reverts commit 1bc10af.
|
Hi @marbre, @stellaraccident, @saienduri, @sjain-stanford can you take a look please? Don't have write permissions in this repo, so just tagging you all. Thanks! |
I was made aware of this issue during the LLVM dev mtg but didn't had a chance to yank old releases as I was still traveling. Hoping to find a bit more time soon. |
|
As another user/stakeholder of the python packages -- thank you, @sahas3! Upon discussion with @marbre and @banach-space, we also figured the 1000 files limit is the current issue. The changes you propose seem right on the money to me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG % minor comments/suggestions
Thanks for implementing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG % minor comments/suggestions
Thanks for implementing this!
51890ea to
5d1fa67
Compare
Releasing the wheels has been failing for a month now https://github.com/llvm/torch-mlir-release/actions/runs/19032410905/job/54349329471#step:7:30 due to the GH limit that each release artifact can only have a maximum of 1000 artifacts (some discussion captured here https://github.com/orgs/community/discussions/165616).
This PR has two changes:
An alternative to keeping all the assets will probably be to release the assets with new name daily but seems overkill to me. Open to other suggestions as well.
artifactErrorsFailBuildflag on the release CIs which I think will cause the builds to fail if the upload step fails -- currently the build doesn't fail which is why I think we didn't notice this earlier.