[TSan][Test-Only][Darwin] Fix typo in external.cpp again #165612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2ecb748 I made an adjustment to the FileCheck for the external.cpp test; unfortunately I corrected both instances of read-only to Read-only when it should have just been the first. This patch fixes it. rdar://160818196
llvmbot
added
compiler-rt
compiler-rt:tsan
Member
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Dan Blackwell (DanBlackwell) ChangesIn 2ecb748 I made an adjustment to the FileCheck for the external.cpp test; unfortunately I corrected both instances of read-only to Read-only when it should have just been the first. This patch fixes it. rdar://160818196 Full diff: https://github.com/llvm/llvm-project/pull/165612.diff 1 Files Affected:
diff --git a/compiler-rt/test/tsan/Darwin/external.cpp b/compiler-rt/test/tsan/Darwin/external.cpp
index 8372a1eb125f3..bf189eb1d6b5b 100644
--- a/compiler-rt/test/tsan/Darwin/external.cpp
+++ b/compiler-rt/test/tsan/Darwin/external.cpp
@@ -70,7 +70,7 @@ int main(int argc, char *argv[]) {
// TEST3: WARNING: ThreadSanitizer: race on MyLibrary::MyObject
// TEST3: {{Modifying|Read-only}} access of MyLibrary::MyObject at
// TEST3: {{ObjectWrite|ObjectRead}}
- // TEST3: Previous {{modifying|Read-only}} access of MyLibrary::MyObject at
+ // TEST3: Previous {{modifying|read-only}} access of MyLibrary::MyObject at
// TEST3: {{ObjectWrite|ObjectRead}}
// TEST3: Location is MyLibrary::MyObject of size 16 at
// TEST3: {{ObjectCreate}}
|
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
DEBADRIBASAK
pushed a commit
to DEBADRIBASAK/llvm-project
that referenced
this pull request
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2ecb748 I made an adjustment to the FileCheck for the external.cpp test; unfortunately I corrected both instances of read-only to Read-only when it should have just been the first.
This patch fixes it.
rdar://160818196