Skip to content

[mlir][sparse] Include sparse emit strategy in wrapping iterator #165611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

[mlir][sparse] Include sparse emit strategy in wrapping iterator #165611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions mlir/lib/Dialect/SparseTensor/Transforms/Utils/SparseTensorIterator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,14 @@ class SimpleWrapIterator : public SparseIterator {
unsigned extraCursorVal = 0)
: SparseIterator(kind, *wrap, extraCursorVal), wrap(std::move(wrap)) {}

void setSparseEmitStrategy(SparseEmitStrategy strategy) override {
wrap->setSparseEmitStrategy(strategy);
}

SparseEmitStrategy getSparseEmitStrategy() const override {
return wrap->getSparseEmitStrategy();
}

SmallVector<Type> getCursorValTypes(OpBuilder &b) const override {
return wrap->getCursorValTypes(b);
}
Expand Down Expand Up @@ -979,7 +987,7 @@ class SubSectIterator : public SparseIterator {

void SparseIterator::genInit(OpBuilder &b, Location l,
const SparseIterator *p) {
if (emitStrategy == SparseEmitStrategy::kDebugInterface) {
if (getSparseEmitStrategy() == SparseEmitStrategy::kDebugInterface) {
std::string prefix = getDebugInterfacePrefix();
Operation *begin = b.create(l, b.getStringAttr(prefix + ".begin"), {},
getCursorValTypes(b));
Expand All @@ -994,7 +1002,7 @@ void SparseIterator::genInit(OpBuilder &b, Location l,
}

Value SparseIterator::genNotEnd(OpBuilder &b, Location l) {
if (emitStrategy == SparseEmitStrategy::kDebugInterface) {
if (getSparseEmitStrategy() == SparseEmitStrategy::kDebugInterface) {
std::string prefix = getDebugInterfacePrefix();
Operation *notEnd = b.create(l, b.getStringAttr(prefix + ".not_end"),
getCursor(), b.getI1Type());
Expand All @@ -1005,7 +1013,7 @@ Value SparseIterator::genNotEnd(OpBuilder &b, Location l) {
}

void SparseIterator::locate(OpBuilder &b, Location l, Value crd) {
if (emitStrategy == SparseEmitStrategy::kDebugInterface) {
if (getSparseEmitStrategy() == SparseEmitStrategy::kDebugInterface) {
std::string prefix = getDebugInterfacePrefix();
SmallVector<Value> args = getCursor();
args.push_back(crd);
Expand All @@ -1019,7 +1027,7 @@ void SparseIterator::locate(OpBuilder &b, Location l, Value crd) {
}

Value SparseIterator::deref(OpBuilder &b, Location l) {
if (emitStrategy == SparseEmitStrategy::kDebugInterface) {
if (getSparseEmitStrategy() == SparseEmitStrategy::kDebugInterface) {
std::string prefix = getDebugInterfacePrefix();
SmallVector<Value> args = getCursor();
Operation *deref = b.create(l, b.getStringAttr(prefix + ".deref"),
Expand All @@ -1032,7 +1040,7 @@ Value SparseIterator::deref(OpBuilder &b, Location l) {

ValueRange SparseIterator::forward(OpBuilder &b, Location l) {
assert(!randomAccessible());
if (emitStrategy == SparseEmitStrategy::kDebugInterface) {
if (getSparseEmitStrategy() == SparseEmitStrategy::kDebugInterface) {
std::string prefix = getDebugInterfacePrefix();
Operation *next = b.create(l, b.getStringAttr(prefix + ".next"),
getCursor(), getCursorValTypes(b));
Expand Down
6 changes: 5 additions & 1 deletion mlir/lib/Dialect/SparseTensor/Transforms/Utils/SparseTensorIterator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,10 +177,14 @@ class SparseIterator {
public:
virtual ~SparseIterator() = default;

void setSparseEmitStrategy(SparseEmitStrategy strategy) {
virtual void setSparseEmitStrategy(SparseEmitStrategy strategy) {
emitStrategy = strategy;
}

virtual SparseEmitStrategy getSparseEmitStrategy() const {
return emitStrategy;
}

virtual std::string getDebugInterfacePrefix() const = 0;
virtual SmallVector<Type> getCursorValTypes(OpBuilder &b) const = 0;

Expand Down