-
-
Notifications
You must be signed in to change notification settings - Fork 84
Enabled cache stampede protection #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled cache stampede protection #443
Conversation
|
Hey @MarkCiliaVincenti - that is a good one. Instead of rolling out a custom version, I'd prefer either something like Microsofts Reason being is that the internals on how the protection is happening is part of the implementation and doesn't spill out to the using object. |
|
What do you think now, @linkdotnet? |
linkdotnet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good direction - I think we can reduce some complexity and role with "more" default-ish settings.
...s/LinkDotNet.Blog.IntegrationTests/Infrastructure/Persistence/Sql/BlogPostRepositoryTests.cs
Show resolved
Hide resolved
Removed singleton registration for AsyncKeyedLocker.
Removed unused AsyncKeyedLock namespace.
src/LinkDotNet.Blog.Infrastructure/Persistence/CachedRepository.cs
Outdated
Show resolved
Hide resolved
|
I have a question.
|
|
Basically: Yes. And to some extent because th API surface of FusionCache is nice. if someone wants to use redis or so on top - it would be just a matter of a few more extra lines of code. |
Also allows configuration of sliding expiration.