[Part 2|*] Implement First Part for SQL Backend functions #10287

ziggie1984 · 2025-10-12T17:19:01Z

Depends on #9147

This PR implements the QueryPayments and FetchPayment SQL Payments DB backend functions.

It does not yet add testing for these functions which will be added in followup PRs once we have the ability to add payments and attempts to the database which we then can fetch.

ziggie1984 · 2025-10-17T07:53:48Z

/gemini review

gemini-code-assist

Code Review

This pull request implements the QueryPayments and FetchPayment functions for the new SQL backend of the payments database. The changes include new SQL queries, Go functions to execute them, and converters to transform database results into application-level types.

The implementation is well-structured, making good use of batching for efficient data fetching. I have a few suggestions to improve code clarity and adhere to best practices:

Simplify time value handling in sql_converters.go by using direct type assertions where the type is guaranteed.
Consider updating the DB interface to accept a context.Context in FetchPayment to avoid using context.TODO().
I also found a minor typo in a comment.

Overall, this is a solid contribution towards the SQL backend migration.

payments/db/sql_converters.go

payments/db/sql_store.go

ellemouton

lgtm!

sqldb/sqlc/queries/payments.sql

ellemouton · 2025-10-21T10:49:11Z

payments/db/sql_store.go

+	}, func() {
+	})


sqldb.NoOpReset

Not addressed

ellemouton · 2025-10-21T10:54:00Z

payments/db/sql_store.go

+
+// fetchHTLCAttemptsForPayment fetches all HTLC attempts for a payment and
+// uses ExecuteBatchQuery to efficiently fetch hops and custom records.
+func (s *SQLStore) fetchHTLCAttemptsForPayment(ctx context.Context,


ah, you can probably come back to this at the performance improvement stage like i did for graph stuff, but i think you can improve performance here quite a bit still: currently it is still only doing payment by payment. So it isnt taking full advantage of the batch query helper. You could instead batch fetch the components for a whole range of payment IDs in one go

@ziggie1984 will this be addressed in the later PRs?

lightninglabs-deploy · 2025-10-28T11:39:25Z

@ziggie1984, remember to re-request review from reviewers when ready

yyforyongyu

I think it's expected that two itests will be failing correct? If so we can merge this one and address the issues here in the next PR.

yyforyongyu · 2025-10-28T11:11:14Z

sqldb/sqlc/queries/payments.sql

+-- name: FetchAllInflightAttempts :many
+-- Fetch all inflight attempts across all payments
+SELECT
+    ha.id,


should we use sqlc.embed(ha) instead?

yyforyongyu · 2025-10-28T12:15:00Z

payments/db/sql_converters.go

+	attempt := &HTLCAttempt{
+		HTLCAttemptInfo: info,
+	}
+


nit: can exit early when if !dbAttempt.ResolutionType.Valid

yyforyongyu · 2025-10-28T12:15:59Z

payments/db/sql_store.go

+
+// fetchHTLCAttemptsForPayment fetches all HTLC attempts for a payment and
+// uses ExecuteBatchQuery to efficiently fetch hops and custom records.
+func (s *SQLStore) fetchHTLCAttemptsForPayment(ctx context.Context,


@ziggie1984 will this be addressed in the later PRs?

yyforyongyu · 2025-10-28T12:21:57Z

payments/db/sql_store.go

+	}, func() {
+	})
+	if err != nil {
+		return nil, fmt.Errorf("failed to fetch payment: %w", err)


This wrapping is redundant

yyforyongyu · 2025-10-28T12:24:32Z

payments/db/sql_store.go

+	}, func() {
+	})


Not addressed

ziggie1984 changed the base branch from master to elle-payment-sql-series-new October 12, 2025 17:19

ziggie1984 force-pushed the introduce-sql-schema-payments-part-2 branch 2 times, most recently from fe51267 to 63aa866 Compare October 12, 2025 17:33

ziggie1984 self-assigned this Oct 13, 2025

ziggie1984 added payments Related to invoices/payments sql labels Oct 13, 2025

ziggie1984 added this to v0.21 Oct 13, 2025

ziggie1984 added this to the v0.21.0 milestone Oct 13, 2025

ziggie1984 force-pushed the introduce-sql-schema-payments-part-2 branch from 938443e to b0361a2 Compare October 13, 2025 07:00

ziggie1984 added the database Related to the database/storage of LND label Oct 13, 2025

ziggie1984 force-pushed the introduce-sql-schema-payments-part-2 branch from b0361a2 to ed283fa Compare October 13, 2025 14:49

ziggie1984 mentioned this pull request Oct 13, 2025

[Part 3|*] Implement Second Part for SQL Backend functions #10291

Open

saubyk moved this to In progress in v0.21 Oct 14, 2025

ziggie1984 changed the title ~~[Part 2|*] Implement QueryPayments for SQL Backend~~ [Part 2|*] Implement First Part for SQL Backend functions Oct 15, 2025

ziggie1984 force-pushed the introduce-sql-schema-payments-part-2 branch from ed283fa to aa560da Compare October 15, 2025 12:49

ziggie1984 marked this pull request as ready for review October 15, 2025 13:09

ziggie1984 force-pushed the introduce-sql-schema-payments-part-2 branch from aa560da to 08464ea Compare October 15, 2025 13:13

sqldb: add index and comment to payment tables

18f03ec

ziggie1984 force-pushed the introduce-sql-schema-payments-part-2 branch from 08464ea to da3603e Compare October 15, 2025 13:14

ziggie1984 requested review from ellemouton and yyforyongyu October 15, 2025 13:15

ziggie1984 force-pushed the introduce-sql-schema-payments-part-2 branch from da3603e to 069f7c6 Compare October 15, 2025 13:25

ziggie1984 removed request for ellemouton and yyforyongyu October 15, 2025 13:26

ziggie1984 mentioned this pull request Oct 15, 2025

[Part 4|*] Add unit tests for the previous introduced SQL Backend methods #10292

Open

ziggie1984 force-pushed the introduce-sql-schema-payments-part-2 branch 2 times, most recently from 1f7d395 to ef6ef5c Compare October 17, 2025 07:53

gemini-code-assist bot reviewed Oct 17, 2025

View reviewed changes

payments/db/sql_converters.go Outdated Show resolved Hide resolved

payments/db/sql_converters.go Outdated Show resolved Hide resolved

payments/db/sql_store.go Outdated Show resolved Hide resolved

payments/db/sql_store.go Show resolved Hide resolved

multi: add relevant queries for QueryPayments implemenation

c908b52

ziggie1984 added 4 commits October 17, 2025 10:20

paymentsdb: add new internal error

52d466f

paymentsdb: implement QueryPayments for sql backend

353160c

paymentsdb: implement FetchPayment for sql backend

fc4ce67

docs: add release-notes

0849296

ziggie1984 force-pushed the introduce-sql-schema-payments-part-2 branch from ef6ef5c to 0849296 Compare October 17, 2025 08:43

ziggie1984 requested review from ellemouton and yyforyongyu October 17, 2025 08:44

ziggie1984 mentioned this pull request Oct 17, 2025

[feature]: Introduce Payment SQL storage #9863

Open

6 tasks

ziggie1984 moved this from In progress to In review in v0.21 Oct 18, 2025

ellemouton approved these changes Oct 21, 2025

View reviewed changes

ellemouton reviewed Oct 21, 2025

View reviewed changes

yyforyongyu reviewed Oct 28, 2025

View reviewed changes

[Part 2|*] Implement First Part for SQL Backend functions #10287

Are you sure you want to change the base?

[Part 2|*] Implement First Part for SQL Backend functions #10287

Uh oh!

Conversation

ziggie1984 commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ziggie1984 commented Oct 17, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ellemouton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lightninglabs-deploy commented Oct 28, 2025

Uh oh!

yyforyongyu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ziggie1984 commented Oct 12, 2025 •

edited

Loading