Remove get_revoke_commit_msgs macro
#4215
Merged
+54
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace calls to `get_revoke_commit_msgs` macro to the identically-named function.
|
👋 I see @valentinewallace was un-assigned. |
wpaulino
approved these changes
Nov 10, 2025
Contributor
wpaulino
left a comment
wpaulino
left a comment
There was a problem hiding this comment.
Would be nice to also remove the get_htlc_update_msgs one
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4215 +/- ##
==========================================
- Coverage 89.33% 89.31% -0.02%
==========================================
Files 180 180
Lines 138055 138055
Branches 138055 138055
==========================================
- Hits 123326 123306 -20
- Misses 12122 12145 +23
+ Partials 2607 2604 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
was planning on doing that one and some others I think can be removed as well in a different PR. LMK if that works. |
tnull
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the last remaining calls to
get_revoke_commit_msgsmacro to the identically-named function.