Skip to content

[CI] add kvm-docker-linux-x86-64 integration test in prow #21556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[CI] add kvm-docker-linux-x86-64 integration test in prow #21556

wants to merge 4 commits into from
+2,018 −1

Conversation

@ComradeProgrammer
Copy link
Member

@ComradeProgrammer ComradeProgrammer commented Sep 14, 2025 •
edited
Loading

  1. implement a new binary minitest to allocate a new test environment(gcp project) via boskos in prow
  2. migrate old KVM_Linux integration test into prow

closes #21332

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ComradeProgrammer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from nirs September 14, 2025 23:23
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 14, 2025
@ComradeProgrammer ComradeProgrammer force-pushed the kvm_prow branch 3 times, most recently from c19610d to a232d5e Compare September 14, 2025 23:37
medyagh
medyagh reviewed Sep 22, 2025
View reviewed changes
medyagh
medyagh reviewed Sep 22, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 27, 2025
@ComradeProgrammer ComradeProgrammer force-pushed the kvm_prow branch 7 times, most recently from 6543f9a to a0e55b8 Compare September 28, 2025 22:21
@ComradeProgrammer ComradeProgrammer force-pushed the kvm_prow branch 3 times, most recently from 6f29cd6 to a961e63 Compare October 11, 2025 19:28
@ComradeProgrammer ComradeProgrammer changed the title [WIP][CI] add minikubekvm integration test in prow [CI] add minikubekvm integration test in prow Oct 11, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 12, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot removed the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 12, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 12, 2025
@medyagh medyagh mentioned this pull request Oct 13, 2025
Open
medyagh
medyagh reviewed Oct 13, 2025
View reviewed changes
medyagh
medyagh reviewed Oct 13, 2025
View reviewed changes
medyagh
medyagh reviewed Oct 13, 2025
View reviewed changes
medyagh
medyagh requested changes Oct 13, 2025
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @ComradeProgrammer I am very excited to see this merged soon

lets do the following

1- Lets try to see if we can use Nested Images simmilar to "https://brianlinkletter.com/2017/12/enable-nested-virtualization-on-google-cloud/". we can find newer images simmilar to it
2- Change the test names
3- Add Gopogh Artifacts

@prezha prezha mentioned this pull request Oct 19, 2025
Merged
@ComradeProgrammer ComradeProgrammer force-pushed the kvm_prow branch 3 times, most recently from 7db7229 to 1460da9 Compare October 19, 2025 19:37
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 19, 2025
@ComradeProgrammer ComradeProgrammer force-pushed the kvm_prow branch 2 times, most recently from b34bfc8 to 1b5d436 Compare October 19, 2025 20:49
@ComradeProgrammer
Copy link
Member Author

last ci: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/minikube/21556/pull-minikube-integration/1980024424698482688 it's green

@ComradeProgrammer ComradeProgrammer force-pushed the kvm_prow branch 2 times, most recently from cb6d72d to 3c116bd Compare October 26, 2025 20:42
@ComradeProgrammer ComradeProgrammer changed the title [CI] add minikubekvm integration test in prow [CI] add kvm-docker-linux-x86-64 integration test in prow Oct 26, 2025
medyagh
medyagh requested changes Oct 27, 2025
View reviewed changes
@medyagh
Copy link
Member

medyagh commented Oct 30, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 30, 2025
@k8s-ci-robot
Copy link
Contributor

@ComradeProgrammer: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-kvm-containerd-linux-x86-64 9559ab2 link true /test integration-kvm-containerd-linux-x86-64
integration-kvm-crio-linux-x86-64 9559ab2 link true /test integration-kvm-crio-linux-x86-64
integration-docker-crio-linux-x86-64 9559ab2 link true /test integration-docker-crio-linux-x86-64
integration-none-docker-linux-x86-64 9559ab2 link true /test integration-none-docker-linux-x86-64
integration-docker-docker-linux-x86-64 9559ab2 link true /test integration-docker-docker-linux-x86-64
integration-docker-containerd-linux-x86-64 9559ab2 link true /test integration-docker-containerd-linux-x86-64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

medyagh
medyagh requested changes Oct 30, 2025
View reviewed changes
hack/prow/installer/check_install_gopogh.sh

set -eux -o pipefail

go install github.com/medyagh/gopogh/cmd/gopogh@v0.29.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add this file to the gopogh updater in hack folder to make sure it gets updated

hack/prow/installer/check_install_gotestsum.sh

function install_gotestsum() {
rm -f $(which gotestsum)
sudo env "GOBIN=$GOROOT/bin" "PATH=$PATH" go install gotest.tools/gotestsum@v1.12.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the hack updater should check here too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@medyagh medyagh medyagh requested changes

@nirs nirs Awaiting requested review from nirs

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Run Full KVM integration test in Prow

3 participants

@ComradeProgrammer @k8s-ci-robot @medyagh