Skip to content

Conversation

@mikebryant
Copy link

Fixes #2434

Description

The current algorithm doesn't deal well with:

  • Multiple mutually exclusive NodePools
  • Nodes spread across AZs with topologySpreadConstraints
    as it orders the Nodes, and then all consolidations must be of a consecutive sequence.

This preserves the existing behaviour as a default, but then can optionally shuffle the order in order to attempt to find other consolidation opportunities.

How was this change tested?

I've been using karpenter-provider-aws per the docs with the karpenter dependency replaced locally.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The current algorithm doesn't deal well with:
- Multiple mutually exclusive NodePools
- Nodes spread across AZs with topologySpreadConstraints
as it orders the Nodes, and then all consolidations must be of a consecutive sequence.

This preserves the existing behaviour as a default, but then can optionally shuffle the order in order to attempt to find other consolidation opportunities.
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mikebryant
Once this PR has been reviewed and has the lgtm label, please assign ellistarn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @mikebryant!

It looks like this is your first PR to kubernetes-sigs/karpenter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/karpenter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 25, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @mikebryant. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 25, 2025
@mikebryant mikebryant changed the title feat: Add random shuffles in multi-node consolidation WIP: feat: Add random shuffles in multi-node consolidation Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multinode consolidation delayed/stuck

2 participants