Skip to content

Conversation

@dougloyo
Copy link

@dougloyo dougloyo commented Mar 2, 2018

Hi,

This pull request enables options change watch to trigger an update on the countUp instance if any property of the options object changes.
Use case: We needed to dynamically change the suffix part of the options. For example: if our number was a percentage "97%" and then we needed it to be a number "183.23" we needed to change the options.suffix value and have countUp update.

Additionally we cleaned up the options extend because generally speaking this is when your plugin or module has default options to be replaced with the ones being passed in.
For example:
if you had: var options={ someDefaultValue:5 }; inside of your module/plugin.
you would use extends to override that value.
$scope.options would probably be = { someDefaultValue:6, otherValue:10 }
angular.extend(options, $scope.options);

Please let me know if this makes sense.

@inorganik
Copy link
Owner

Looks good, you just need to build your changes with gulp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants