-
Notifications
You must be signed in to change notification settings - Fork 3k
Add fasta support #7851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add fasta support #7851
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
lhoestq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good ! I just left minor comments
| ".ffn": ("fasta", {}), | ||
| ".frn": ("fasta", {}), | ||
| } | ||
| _EXTENSION_TO_MODULE.update({ext: ("imagefolder", {}) for ext in imagefolder.ImageFolder.EXTENSIONS}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also add the upper versions of the extensions here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, but why do none of the other extensions have uppers?
| import datasets | ||
| from datasets.features import Value | ||
| from datasets.table import table_cast | ||
| from datasets.utils.file_utils import xopen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for xopen, you can use regular open (it's replaced by xopen anyway when needed due to an old logic)
…gingface#7848) remove mode parameter in docstring of pdf and video feature
|
A few comments:
|
What @apcamargo said, plus FWIW in our approach (so might not be relevant here) we use polars (with custom fasta io parser) or polars-bio (that has a Which in polars can be solved with: |
This PR adds support for FASTA files conversion to Parquet.