feat: Add set node account id method #362

aceppaluni · 2025-09-08T16:27:04Z

Description:
Add Set_node_account_ids() method to Query and Transaction for retrieving receipts or records.

Added methods to both Query and Transaction
Added unit test for Query
Added unit test for Transaction

Related issue(s):

Fixes #86

Notes for reviewer:
Ran tests for both Query and Transaction

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Angelina <aceppaluni@gmail.com>

Signed-off-by: dosi <dosi.kolev@limechain.tech>

…xamples Signed-off-by: dosi <dosi.kolev@limechain.tech>

Signed-off-by: dosi <dosi.kolev@limechain.tech>

exploreriii

Hi @accepaluni please remember to pre-fix your PR title eg
feat: add set node account id method
additionally, we now have a changelog, which must be updated with each PR

src/hiero_sdk_python/transaction/transaction.py

nadineloepfe · 2025-10-06T14:49:00Z

Hi @aceppaluni,
are you still working on this?
also, would you mind adding a "feat:" in front of your PR title as well as an entry in the CHANGELOG? thanks

aceppaluni · 2025-10-14T21:29:41Z

Hi @nadineloepfe Yes, my apologies.
I have been a bit busier then normal. Of course, will do, thank you!

exploreriii

Hi @aceppaluni
One of your workflows threw an error
ERROR tests/integration/transfer_transaction_e2e_test.py - NameError: name 'List' is not defined
ERROR tests/integration/utils_for_test.py - NameError: name 'List' is not defined
ERROR tests/unit - NameError: name 'List' is not defined
Please check :)
thanks

aceppaluni · 2025-10-28T15:40:28Z

@exploreriii I believe the error should be corrected now.

src/hiero_sdk_python/query/query.py

nadineloepfe · 2025-10-29T10:01:15Z

src/hiero_sdk_python/transaction/transaction.py

+
+    def set_node_account_id(self, node_account_id: AccountId):
+        """
+        Selects a node account ID to use for sending a query.


this should be "sending a transaction"

nadineloepfe · 2025-10-29T10:01:45Z

src/hiero_sdk_python/transaction/transaction.py

+
+    def _select_node_account_id(self) -> Optional[AccountId]:
+        """
+        Selects a node account ID to use for sending a query.


this also should say "sending a transaction"

nadineloepfe · 2025-10-29T10:02:21Z

src/hiero_sdk_python/query/query.py

+            selected = self.node_account_ids[0]
+            self._used_node_account_id = selected 
+            return selected 
+        return None


could we end this file with a new line (python convcention)

nadineloepfe · 2025-10-29T10:03:12Z

CHANGELOG.md


 ### Fixed
 - Added explicit read permissions to examples.yml (#623)
+- fix: spacing after set_node_account_id method (#362)


the changelog entry should be: "added node_account_ids method" or similar, not spacing

nadineloepfe · 2025-10-29T10:05:32Z

You need to modify the _execute method in executable.py to check if node_account_ids has been set and use _select_node_account_id() if available, otherwise fall back to client.network.current_node. else the
_select_node_account_id() methods you added are never actually
called.

also, please add an integration test (or raise a ticket so someone can pick this up later - executable as well as integration) :)

aceppaluni · 2025-10-29T15:34:33Z

@nadineloepfe I will raise a ticket for the integration testing. :)

exploreriii

hi @aceppaluni note that the workflow has failed due to
ERROR tests/integration/token_pause_transaction_e2e_test.py::test_pause_sets_pause_status_to_paused - AttributeError: 'Network' object has no attribute '_get_node'. Did you mean: '_select_node'?

nadineloepfe · 2025-11-04T05:15:01Z

@aceppaluni : in executable.py, the code calls node = client.network._select_node(self.node_account_id)

But _select_node() in network.py doesn't accept any parameters yet, thus you see the errors.
I'd suggest to add a _get_node() method to the Network class that accepts an account ID and returns the matching node

nadineloepfe · 2025-11-07T13:17:45Z

ok I see the problem.

we need to match the JavaScript SDK architecture. in short: we should move the node account ID management methods to the _Executable base class.. then Tansaction.py overrides setNodeAccountIds() to add frozen state validation, and both Transaction and Query inherit the functionality without code duplication, and the pipeline should pass

Signed-off-by: Angelina <aceppaluni@gmail.com>

…election Signed-off-by: Angelina <aceppaluni@gmail.com>

…ion flow (hiero-ledger#362) Signed-off-by: Angelina <aceppaluni@gmail.com>

aceppaluni and others added 21 commits May 22, 2025 10:26

add tokenInfoQuery functionality

f694268

Signed-off-by: Angelina <aceppaluni@gmail.com>

refactor: update TokenInfoQuery implementation

d5310c8

Signed-off-by: dosi <dosi.kolev@limechain.tech>

test: add unit tests

76b0d85

Signed-off-by: dosi <dosi.kolev@limechain.tech>

test: add integration tests

256e807

Signed-off-by: dosi <dosi.kolev@limechain.tech>

docs: add examples for both non-fungible/fungible tokens

32443f1

Signed-off-by: dosi <dosi.kolev@limechain.tech>

docs: update README in examples

3c3a6ea

Signed-off-by: dosi <dosi.kolev@limechain.tech>

chore: add TokenInfoQuery to __init__.py

1a453ee

Signed-off-by: dosi <dosi.kolev@limechain.tech>

test: reduce test_token_info_query_execute function length

1c6ac60

Signed-off-by: dosi <dosi.kolev@limechain.tech>

test: fix incorrect integration test function names

df1069c

Signed-off-by: dosi <dosi.kolev@limechain.tech>

docs: change network from solo to testnet and some minor changes in e…

67c9eb7

…xamples Signed-off-by: dosi <dosi.kolev@limechain.tech>

test: address PR comments for integration/unit tests

d7d6c18

Signed-off-by: dosi <dosi.kolev@limechain.tech>

docs: update examples for TokenInfoQuery to address PR comments

79c1f10

Signed-off-by: dosi <dosi.kolev@limechain.tech>

Merge branch 'hiero-ledger:main' into main

a4372ad

Merge branch 'hiero-ledger:main' into main

17ace16

Merge branch 'hiero-ledger:main' into main

090b2bb

Merge branch 'hiero-ledger:main' into main

854c0ca

Merge branch 'hiero-ledger:main' into main

168d706

Merge branch 'hiero-ledger:main' into main

143b727

Merge branch 'hiero-ledger:main' into main

ad6df88

Merge branch 'hiero-ledger:main' into main

fdcc0cb

Merge branch 'hiero-ledger:main' into main

b9ad245

aceppaluni marked this pull request as ready for review September 9, 2025 14:24

exploreriii requested changes Sep 9, 2025

View reviewed changes

src/hiero_sdk_python/transaction/transaction.py Outdated Show resolved Hide resolved

src/hiero_sdk_python/transaction/transaction.py Outdated Show resolved Hide resolved

Merge branch 'hiero-ledger:main' into main

7f4ee47

Merge branch 'hiero-ledger:main' into main

e17c504

aceppaluni changed the title ~~Add set node account id method~~ feat: Add set node account id method Oct 20, 2025

aceppaluni added 2 commits October 20, 2025 18:42

Merge branch 'hiero-ledger:main' into main

22ba822

Merge branch 'hiero-ledger:main' into main

2741bde

aceppaluni force-pushed the AddSetNodeAccountIdMethod branch from cd30c5d to 395fadf Compare October 27, 2025 21:33

exploreriii requested changes Oct 28, 2025

View reviewed changes

Merge branch 'hiero-ledger:main' into main

9328d1f

aceppaluni force-pushed the AddSetNodeAccountIdMethod branch from 094195f to 6abf051 Compare October 28, 2025 15:38

nadineloepfe requested changes Oct 28, 2025

View reviewed changes

src/hiero_sdk_python/query/query.py Outdated Show resolved Hide resolved

Merge branch 'hiero-ledger:main' into main

e594364

aceppaluni force-pushed the AddSetNodeAccountIdMethod branch from b09233a to 2afb18d Compare October 28, 2025 21:41

nadineloepfe requested changes Oct 29, 2025

View reviewed changes

Merge branch 'hiero-ledger:main' into main

a5267b8

aceppaluni force-pushed the AddSetNodeAccountIdMethod branch from 591a4b6 to ab18528 Compare October 29, 2025 15:30

exploreriii requested changes Oct 29, 2025

View reviewed changes

Merge branch 'hiero-ledger:main' into main

13b3573

aceppaluni force-pushed the AddSetNodeAccountIdMethod branch from ab18528 to df7a63a Compare October 30, 2025 15:40

Merge branch 'hiero-ledger:main' into main

177248e

aceppaluni force-pushed the AddSetNodeAccountIdMethod branch 2 times, most recently from 4d9bd11 to 6e60202 Compare November 4, 2025 17:01

aceppaluni and others added 8 commits November 9, 2025 17:22

Merge branch 'hiero-ledger:main' into main

7744971

Add set_node_account_id method

7296504

Signed-off-by: Angelina <aceppaluni@gmail.com>

fix: add missing List import and update changelog

e26ce81

Signed-off-by: Angelina <aceppaluni@gmail.com>

style: add spacing in set_node_account_id method

2549536

Signed-off-by: Angelina <aceppaluni@gmail.com>

feat: support selecting node account ID for execution flow

76c4b8e

Signed-off-by: Angelina <aceppaluni@gmail.com>

Fix node selection to use _select_node instead of _get_node

544e8e3

Signed-off-by: Angelina <aceppaluni@gmail.com>

feat: add Network._get_node() and update executable to support node s…

af00187

…election Signed-off-by: Angelina <aceppaluni@gmail.com>

feat: move node account ID selection to _Executable and update execut…

bdcc2a4

…ion flow (hiero-ledger#362) Signed-off-by: Angelina <aceppaluni@gmail.com>

aceppaluni force-pushed the AddSetNodeAccountIdMethod branch from 6e60202 to bdcc2a4 Compare November 10, 2025 16:26

feat: Add set node account id method #362

Are you sure you want to change the base?

feat: Add set node account id method #362

Conversation

aceppaluni commented Sep 8, 2025

Uh oh!

exploreriii left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nadineloepfe commented Oct 6, 2025

Uh oh!

aceppaluni commented Oct 14, 2025

Uh oh!

exploreriii left a comment

Choose a reason for hiding this comment

Uh oh!

aceppaluni commented Oct 28, 2025

Uh oh!

Uh oh!

nadineloepfe Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

nadineloepfe Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

nadineloepfe Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

nadineloepfe Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

nadineloepfe commented Oct 29, 2025

Uh oh!

aceppaluni commented Oct 29, 2025

Uh oh!

exploreriii left a comment

Choose a reason for hiding this comment

Uh oh!

nadineloepfe commented Nov 4, 2025

Uh oh!

nadineloepfe commented Nov 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants