HIP: Validate length of names and labels rather than relying on truncation #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jarebudev <23311805+jarebudev@users.noreply.github.com>
Signed-off-by: jarebudev <23311805+jarebudev@users.noreply.github.com>
Signed-off-by: jarebudev <23311805+jarebudev@users.noreply.github.com>
Signed-off-by: jarebudev <23311805+jarebudev@users.noreply.github.com>
Signed-off-by: jarebudev <23311805+jarebudev@users.noreply.github.com>
jarebudev
force-pushed
the
add_hip_auto_truncate_names
branch
from
24ae763 to
f5f9e8a
Compare
|
I stand with this change request. At minimum, the bad practice of truncation must be removed from the default charts. This "fix" is prevalent in most open source charts and doesn't help at all with deployments. Failing fast is preferred to hiding an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new Helm Improvement Proposal (HIP) to change Helm so that names and labels in templates are validated to be less than 63 characters in length before attempting to apply to Kubernetes, and discourage the current convention of truncating and trimming values.