Skip to content

Conversation

@eduardoyutaka
Copy link

Following the suggestion from issue #5662

The turbo drive's attribute [data-turbo-cache=false] was deprecated in favor of data-turbo-temporary

@timdiggins
Copy link

This should work with Turbo >= 7.3.0 and won't work with Turbo < 7.3.0

Could just support latest version of turbo? (break in old Turbo)

Or stick with old turbo? (deprecation warnings on new Turbo)

Could have a turbo compatibility layer:

  <div id="error_explanation" <%= Devise::TurboCompat.gte_730? &&  'data-turbo-temporary' || 'data-turbo-cache="false"' %>>

Given that Turbo is a Js library, it seems tricky to find an automatic way to support different versions of turbo. Would then have to be configured by either an env var or a devise configuration option?

@carlosantoniodasilva carlosantoniodasilva added this to the 5.0 milestone Oct 31, 2025
@carlosantoniodasilva
Copy link
Member

Thanks... I might change this for v5 since we're doing a major anyway, and if people need to support the older version, they can always generate the view and change in their app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants