-
Notifications
You must be signed in to change notification settings - Fork 50
Showcase: convert modifier/helper integration tests to gts or typescript #3366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,225
−991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
aklkv
reviewed
Nov 14, 2025
30be8eb to
179bcf0
Compare
Base automatically changed from
hds-5557/spike/convert-components-to-gts
to
main
November 19, 2025 14:51
2b65a92 to
f23eaf6
Compare
0185f03 to
02f8b66
Compare
02f8b66 to
86db065
Compare
86db065 to
7a3bb2f
Compare
7a3bb2f to
6b2568f
Compare
6b2568f to
e7ee901
Compare
e7ee901 to
3c27aca
Compare
3c27aca to
e9f223d
Compare
e9f223d to
b00132d
Compare
didoo
reviewed
Nov 20, 2025
Contributor
didoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a very quick look, not looked at every detail. Left only a comment.
didoo
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would convert the remaining modifier and helper tests to gts or typescript.
🔗 External links
Jira ticket: HDS-5581
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.