-
Notifications
You must be signed in to change notification settings - Fork 51
[SPIKE] AdvancedTable Filtering - Mega dropdown #3336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dchyun
wants to merge
19
commits into
main
Choose a base branch
from
dchyun/spike-adv-table-filter-bar--dropdown
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4a5caf2 to
a6b9000
Compare
65aae72 to
a800966
Compare
Contributor
π¦ RC Packages PublishedLatest commit: a800966 Published 1 packages@hashicorp/design-system-components@5.1.0-rc-20251106155636 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
This spike explores implementing filtering in the AdvancedTable through a mega dropdown approach.
Preview
π οΈ Detailed description
In this spike a new
FilterBarcomponent is created, which is also added as a contextual block to theAdvancedTable.Component API
In the
FilterBarcomponent, thefiltersargument is the data that is used for the filters that are passed to consumers, and how consumers pass in filters to the component. It's general data structure is as follows:There are various different types of filter types such as
single-select,multi-select,range, andsearch. Each type has its own structure for thedata. For example therangefilter would be structured as follows:When the
onFilterevent occurs after a user adds or removes a filter,filtersis passed to the consumer who can use it to implement their own filtering of their data.The dropdown that contains all of the filter options that can be applied sets the structure for the
filtersdata, and consumers can use contextual components to set all of the filter options in the template.π External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
π Component checklist
π¬ Please consider using conventional comments when reviewing this PR.
π PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.