Math emulation improvements #10176
Open
Math emulation improvements #10176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynek
force-pushed
the
math
branch
6 times, most recently
from
5f1c929 to
b3a1847
Compare
zbynek
added
Category-JRE
ready
niloc132
reviewed
Nov 6, 2025
user/test-super/com/google/gwt/emultest/super/com/google/gwt/emultest/java17/lang/MathTest.java
Outdated
Show resolved
Hide resolved
user/test-super/com/google/gwt/emultest/super/com/google/gwt/emultest/java17/lang/MathTest.java
Show resolved
Hide resolved
user/test-super/com/google/gwt/emultest/super/com/google/gwt/emultest/java17/lang/MathTest.java
Outdated
Show resolved
Hide resolved
Member
|
While reviewing code elsewhere, I also noticed that DoubleTest.testDoubleConstants() has two checks that can be reenabled if we support getExponent() now |
niloc132
reviewed
Nov 7, 2025
dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
Outdated
Show resolved
Hide resolved
Comment on lines
425
to
499
| assertEquals(Double.POSITIVE_INFINITY, Math.hypot(1, Double.NEGATIVE_INFINITY)); | ||
| assertEquals(Double.POSITIVE_INFINITY, Math.hypot(Double.POSITIVE_INFINITY, 1)); | ||
| assertEquals(Double.POSITIVE_INFINITY, Math.hypot(Double.NaN, Double.NEGATIVE_INFINITY)); |
Member
There was a problem hiding this comment.
warning, these are boxing to Double without the third arg (either 0 or EPS in other lines)
zbynek
added a commit
that referenced
this pull request
Nov 8, 2025
SuppressWarnings makes it easier to see which warnings are actually suppressed and removes the need for on/off toggles that might get mismatched. Moved out of #10176
…multest/java17/lang/MathTest.java Co-authored-by: Colin Alworth <colin@vertispan.com>
Co-authored-by: Colin Alworth <colin@vertispan.com>
zbynek
force-pushed
the
math
branch
2 times, most recently
from
d312268 to
cf61d68
Compare
niloc132
approved these changes
Nov 11, 2025
| Double.NEGATIVE_INFINITY), EPS); | ||
| } | ||
|
|
||
| public void testGetExponentWithFolding() { |
Member
There was a problem hiding this comment.
aside, constant folding doesn't work on non-String methods at this time #10147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9711 by using native emulation of
log1p,expm1andhypot.Fixes #9663 by adding the implementation of
IEEEremainderAdds
absExact,multiplyFull,ulp, andgetExponent+ missing variations ofmultiplyExact,floorDiv,floorModfor completeness.Only missing methods for JVM 17 compatibility are
multiplyHighandfmawhich might be better handled in #9909