Feature/sharecard #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR overhauls the share functionality by replacing network-dependent image generation with client-side rendering and simplifying the user experience.
Key changes:
- Removed API routes for SVG/PNG generation in favor of client-side image generation using html-to-image
- Added new ShareCard component with improved mobile UI scaling and consistent styling
- Removed social media sharing in favor of direct image downloads based on user behavior
- Consolidated image generation libraries (dom-to-image, html-to-image, html2canvas, html2pdf.js) which may cause bloat
- Modified ShareModal width from max-w-4xl to max-w-md for better mobile display
The changes look solid but consider:
- Evaluate and remove redundant image generation libraries to reduce bundle size
- Add error handling for client-side image generation
- Test download functionality across different browsers and devices
11 file(s) reviewed, 9 comment(s)
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…file-widget into feature/SHARECARD
|
Somethng still wrong with scroll, dont merge yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a nicer share card for people to use, took out the share because everyone just screenshots anw, download should also work, going to check the vercel for any network issues
fixes #22
fixes #23