Skip to content

Fix black reflections when using a plain color as reflection source #112178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix black reflections when using a plain color as reflection source #112178

wants to merge 1 commit into from
+76 −22

Conversation

@Calinou
Copy link
Member

@Calinou Calinou commented Oct 29, 2025 •
edited
Loading

I've also tested VoxelGI/SDFGI in Forward+, and they look correct now.

TODO

  • Fix color not being applied in Compatibility. I don't know why; I've tried to move the shader block outside of the #ifdef USE_RADIANCE_MAP or using a hardcoded red color to no avail.

Preview

Forward+

Before After
Image Image

Mobile

Before After
Image Image

Compatibility

Before After
Image Image

@Calinou
Fix black reflections when using a plain color as reflection source
173491a 
TODO:

- Fix color not being applied in Compatibility.
@Calinou Calinou added this to the 4.6 milestone Oct 29, 2025
@Calinou Calinou added bug topic:rendering topic:3d cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Oct 29, 2025
Kaleb-Reid
Kaleb-Reid reviewed Oct 30, 2025
View reviewed changes
drivers/gles3/rasterizer_scene_gles3.cpp

const RS::EnvironmentReflectionSource ref_src = environment_get_reflection_source(p_render_data->environment);
scene_state.data.use_reflection_color = (ref_src == RS::ENV_REFLECTION_SOURCE_BG && env_bg == RS::ENV_BG_SKY) || ref_src == RS::ENV_REFLECTION_SOURCE_SKY;
scene_state.data.use_reflection_cubemap = (ref_src == RS::ENV_REFLECTION_SOURCE_BG && env_bg == RS::ENV_BG_COLOR) || (ref_src == RS::ENV_REFLECTION_SOURCE_BG && env_bg == RS::ENV_BG_CLEAR_COLOR);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these bools are swapped. Probably why it doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Kaleb-Reid Kaleb-Reid Kaleb-Reid left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bug cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release topic:rendering topic:3d

Projects

None yet

Milestone

4.6

Development

Successfully merging this pull request may close these issues.

Vulkan: WorldEnvironment - Background Mode Custom Color makes metallic materials reflect pure black

2 participants

@Calinou @Kaleb-Reid