Partners #354
Merged
Partners #354
+5,665
−1,092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expert custom agents to improve your experience when working with C# and WinForms in Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR represents a major refactoring to restructure the repository architecture. The main changes include:
- Reorganization of build scripts and utilities into an
eng/directory - Replacement of custom YAML parser with standard libraries (
js-yamlandvfile-matter) - Addition of new agent support with MCP server integration
- Migration of generated README files to a
docs/directory - New dependencies and validation scripts
- Updates to URL references throughout documentation
Reviewed Changes
Copilot reviewed 53 out of 55 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| yaml-parser.js | Removed custom YAML parser implementation (168 lines deleted) |
| update-readme.js | Removed original README generation script (767 lines deleted) |
| eng/yaml-parser.js | Added new YAML parser using standard libraries (js-yaml, vfile-matter) |
| eng/update-readme.js | Refactored README generation with agent support and MCP integration |
| eng/validate-collections.js | Enhanced validation with agent file support |
| eng/constants.js | Centralized configuration constants |
| eng/github-mcp-registry.json | Added MCP registry data for server discovery |
| package.json | Updated scripts and added new dependencies |
| Multiple prompt files | Updated documentation URLs from root to docs/ directory |
| Multiple collection files | Cleaned up description formatting issues |
| Multiple agent files | Added new custom agent definitions with MCP server configs |
Comments suppressed due to low confidence (1)
eng/validate-collections.js:219
- Superfluous argument passed to function validateAgentFile.
| const path = require("path"); | ||
| const { | ||
| parseCollectionYaml, | ||
| extractMcpServers, |
There was a problem hiding this comment.
Unused variable extractMcpServers.
| if (line.trim() === "---") { | ||
| if (!inFrontmatter) { | ||
| inFrontmatter = true; | ||
| } else if (inFrontmatter && !frontmatterEnded) { |
There was a problem hiding this comment.
This use of variable 'inFrontmatter' always evaluates to true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
node update-readme.jsand verified thatREADME.mdis up to date.Description
Type of Contribution
Additional Notes
By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.