Skip to content

Conversation

@aldy505
Copy link
Collaborator

@aldy505 aldy505 commented Oct 23, 2025

Right now the CI is broken for external contributor due to a step that pushes the snuba-ci image to GHCR. Since everything else uses docker load --input /tmp/snuba-ci.tar, I believe it's better to just delete the command that pushes to GHCR entirely. Therefore CI for external contributor is working again (like this PR).

@aldy505 aldy505 requested a review from a team as a code owner October 23, 2025 00:18
@aldy505 aldy505 changed the title fix(ci): push snuba-ci Docker image only on master branch fix: Make CI works for external contributor Oct 28, 2025
Copy link
Contributor

@phacops phacops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we stop pushing the image to GHCR, devservices stops working. We're going to have to find a different approach.

@aldy505
Copy link
Collaborator Author

aldy505 commented Oct 28, 2025

If we stop pushing the image to GHCR, devservices stops working. We're going to have to find a different approach.

@phacops devservices uses "snuba:nightly", not "snuba-ci:commit_sha"

@phacops
Copy link
Contributor

phacops commented Oct 28, 2025

@phacops devservices uses "snuba:nightly", not "snuba-ci:commit_sha"

Ah, true.

@phacops phacops merged commit 7112f02 into getsentry:master Oct 29, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants