-
Notifications
You must be signed in to change notification settings - Fork 569
feat(integrations): add support for embed_content methods in GoogleGenAI integration #5128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(integrations): add support for embed_content methods in GoogleGenAI integration #5128
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #5128 +/- ##
==========================================
- Coverage 84.00% 83.96% -0.05%
==========================================
Files 180 180
Lines 18081 18245 +164
Branches 3216 3243 +27
==========================================
+ Hits 15189 15319 +130
- Misses 1913 1929 +16
- Partials 979 997 +18
|
| contents = kwargs.get("contents") | ||
| model_name = get_model_name(model) | ||
|
|
||
| return model_name, contents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Positional arguments ignored in embed_content
The prepare_embed_content_args function accepts args but ignores them, only retrieving model and contents from kwargs. This causes missing span data (model name and input text) when embed_content is called with positional arguments, which is a supported usage pattern in the Google GenAI SDK.
| contents = kwargs.get("contents") | ||
| model_name = get_model_name(model) | ||
|
|
||
| return model_name, contents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Positional arguments ignored in embed_content
The prepare_embed_content_args function ignores positional arguments in args, unlike prepare_generate_content_args. This results in missing model name and input data in spans when embed_content is called with positional arguments (e.g., embed_content(model, contents)), which is a supported usage pattern.
Issues
Closes https://linear.app/getsentry/issue/TET-1464/add-embedding-support-for-google-genai