Skip to content

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Nov 6, 2025

Description

Set the default value for max_spans option of LangchainIntegration to None, so that langchain spans are not exited early by default.

Deprecate the option as well, announcing its removal in the next major.

Issues

Closes #4985
Closes PY-1914

Reminders

@linear
Copy link

linear bot commented Nov 6, 2025

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.02%. Comparing base (3bc1d17) to head (c371521).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/langchain.py 37.50% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5074      +/-   ##
==========================================
+ Coverage   79.25%   84.02%   +4.76%     
==========================================
  Files         180      180              
  Lines       18023    18026       +3     
  Branches     3205     3207       +2     
==========================================
+ Hits        14284    15146     +862     
+ Misses       2856     1905     -951     
- Partials      883      975      +92     
Files with missing lines Coverage Δ
sentry_sdk/integrations/langchain.py 68.49% <37.50%> (+0.21%) ⬆️

... and 25 files with indirect coverage changes

@linear
Copy link

linear bot commented Nov 6, 2025

@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review November 6, 2025 10:04
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner November 6, 2025 10:04
@alexander-alderman-webb alexander-alderman-webb changed the title chore: Deprecate maximum lanchain spans option chore: Deprecate maximum LangChain spans option Nov 6, 2025
@alexander-alderman-webb alexander-alderman-webb changed the title chore: Deprecate maximum LangChain spans option chore: Deprecate max_spans LangChain` parameter Nov 17, 2025
@alexander-alderman-webb alexander-alderman-webb changed the title chore: Deprecate max_spans LangChain` parameter chore: Deprecate max_spans LangChain parameter Nov 17, 2025
@alexander-alderman-webb alexander-alderman-webb merged commit 25999b5 into master Nov 18, 2025
131 of 132 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/deprecate-max-spans-langchain branch November 18, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove max_spans from LangchainIntegration

3 participants