-
-
Notifications
You must be signed in to change notification settings - Fork 461
Add AI rules for feature flags #4819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+33
−0
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
5b475d1
Add scope based feature flags
adinauer 74cc427
fix equals
adinauer fb42140
add serialization tests
adinauer 045337a
Create new reference on buffer clone
adinauer c1061ca
add comment explaining the merge method
adinauer 74acb10
optimize merge method
adinauer eeae5c6
make flag and result nullable params
adinauer 21806f2
handle empty/noop buffer on merge and add tests for it
adinauer 95550ec
optimize add method
adinauer 865ad5d
format; fix test
adinauer fa81bf8
Add rules for feature flags and mention in overview_dev
adinauer a5c7aef
Fix duplicate check
adinauer 0ab241e
Update sentry/src/main/java/io/sentry/SentryOptions.java
adinauer 4b757b8
Merge branch 'main' into feat/feature-flags-on-scope
adinauer ab1a146
Format code
getsentry-bot d320dd6
Merge branch 'feat/feature-flags-on-scope' into feat/feature-flags-rules
adinauer 1cbda53
Merge branch 'main' into feat/feature-flags-on-scope
adinauer 15544cd
changelog
adinauer 9ac80b5
nullable getFeatureFlags
adinauer 839d878
Merge branch 'main' into feat/feature-flags-on-scope
adinauer 6041a82
Merge branch 'feat/feature-flags-on-scope' into feat/feature-flags-rules
adinauer 72a2c04
Merge branch 'main' into feat/feature-flags-rules
adinauer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| --- | ||
| alwaysApply: false | ||
| description: Feature Flags | ||
| --- | ||
| # Java SDK Feature Flags | ||
|
|
||
| There is a scope based and a span based API for tracking feature flag evaluations. | ||
|
|
||
| ## Scope Based API | ||
|
|
||
| The `addFeatureFlag` method can be used to track feature flag evaluations. It exists on `Sentry` static API as well as `IScopes` and `IScope`. | ||
|
|
||
| The `maxFeatureFlags` option controls how many flags are tracked per scope and also how many are sent to Sentry as part of events. | ||
| Scope based feature flags can also be disabled by setting the value to 0. Defaults to 100 feature flag evaluations. | ||
|
|
||
| Order of feature flag evaluations is important as we only keep track of the last {maxFeatureFlag} items. | ||
|
|
||
| When a feature flag evluation with the same name is added, the previous one is removed and the new one is stored so that it'll be dropped last. | ||
|
|
||
| When sending out an error event, feature flag buffers from all three scope types (global, isolation and current scope) are merged, chosing the newest {maxFeatureFlag} entries across all scope types. Feature flags are sent as part of the `flags` context. | ||
|
|
||
| ## Span Based API | ||
|
|
||
| tbd | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remember to update it