Increase default max_suspicious_broken_parts to 100 #4011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the max_suspicious_broken_parts setting to adapt to more modern setups
Depending on the environment where self-hosted Sentry is running on, it could happen more than often enough that Clickhouse reports errors like this:
In some cases, the Clickhouse container refuses to restart until that setting is changed in clickhouse/config.xml.
A prior PR where the default setting of 10 was introduced even mentioned the new Clickhouse default of 100, but 10 was submitted, most likely to not break current installations.
In reality, this setting will only be effective when Clickhouse is shut down improperly and tries to recover data at restart. In those cases, users should either have backups to circumvent Clickhouse's self-recovery completely or let it do its job, but with a higher threshold (the de-facto default of 100 since 2022).
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.