Skip to content

Conversation

@stevenobird
Copy link
Contributor

Increase the max_suspicious_broken_parts setting to adapt to more modern setups

Depending on the environment where self-hosted Sentry is running on, it could happen more than often enough that Clickhouse reports errors like this:

Application: DB::Exception: Suspiciously many (12 parts, 0.00 B in total) broken parts to remove while maximum allowed broken parts count is 10. You can change the maximum value with merge tree setting 'max_suspicious_broken_parts' in <merge_tree> configuration section or in table settings in .sql file (don't forget to return setting back to default value):

In some cases, the Clickhouse container refuses to restart until that setting is changed in clickhouse/config.xml.

A prior PR where the default setting of 10 was introduced even mentioned the new Clickhouse default of 100, but 10 was submitted, most likely to not break current installations.

In reality, this setting will only be effective when Clickhouse is shut down improperly and tries to recover data at restart. In those cases, users should either have backups to circumvent Clickhouse's self-recovery completely or let it do its job, but with a higher threshold (the de-facto default of 100 since 2022).

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Increased the max_suspicious_broken_parts setting to adapt to more modern setups
@stevenobird stevenobird marked this pull request as ready for review November 5, 2025 15:10
Copy link
Collaborator

@aldy505 aldy505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not?

@aldy505 aldy505 merged commit 2b0757c into getsentry:master Nov 11, 2025
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants