-
-
Notifications
You must be signed in to change notification settings - Fork 183
lab: Structured data #7560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bastianallgeier
wants to merge
8
commits into
develop-minor
Choose a base branch
from
lab/bastian/structured-data
base: develop-minor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
lab: Structured data #7560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74e7034 to
eb81c64
Compare
eb81c64 to
2f31449
Compare
2f31449 to
1f71f82
Compare
| if ($format === 'auto') { | ||
| $format = 'yaml'; | ||
|
|
||
| if (json_validate($data) === true) { |
Check failure
Code scanning / Psalm
UndefinedFunction Error
Function Kirby\Nodes\json_validate does not exist
| return trim($this->parent?->path() . '/' . $this->id(), '/'); | ||
| } | ||
|
|
||
| public function toArray(Closure|null $callback = null): array |
Check failure
Code scanning / Psalm
ParamNameMismatch Error
Argument 1 of Kirby\Nodes\Nodes::toArray has wrong name $callback, expecting $map as defined by Kirby\Cms\Collection::toArray
| return trim($this->parent?->path() . '/' . $this->id(), '/'); | ||
| } | ||
|
|
||
| public function toArray(Closure|null $callback = null): array |
Check failure
Code scanning / Psalm
ParamNameMismatch Error
Argument 1 of Kirby\Nodes\Nodes::toArray has wrong name $callback, expecting $map as defined by Kirby\Toolkit\Collection::toArray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR explores a new API to query and manipulate nested structured data for structure fields, entry fields, layouts, blocks and even blueprints - basically anything that is expressed in nested arrays.
The hope for this experiment is to create a solid foundation for an PHP API that we can use to access and manipulate deeply nested data in a more performant and reliable way. This would give us the opportunity to build structure, block and layout fields with backend connected drawers and would also be a major step forward for a blueprint editor where we need the same for tabs, columns, fields etc.
Naming
So far, I've called the classes and namespace Module, but that maybe not that great. There's also an idea to refactor our existing Item classes, but that would be quite complex without breaking changes.
Demo
Here`s an example that you can toss into Tinkerwell or a simple test.php to play around with it:
Here's another example: