- 
                Notifications
    You must be signed in to change notification settings 
- Fork 10
Use Lucasfont Alternate font for efficient display #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            weberval
  wants to merge
  3
  commits into
  fossasia:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
weberval-forks:upstream/feat/proporinal_font
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            Use Lucasfont Alternate font for efficient display #86
                    weberval
  wants to merge
  3
  commits into
  fossasia:main
from
weberval-forks:upstream/feat/proporinal_font
  
      
      
   
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    To use the available space on the bade more efficient, I changed the font to u8g2_font_lucasfont_alternate_tf from [u8g2-fonts](https://docs.rs/crate/u8g2-fonts/). Lucasfont Alternate was created by Patrick Lauke and is licensed under [CC BY 3.0](https://creativecommons.org/licenses/by/3.0/). No changes to the font were made.
| Reviewer's GuideReplaces the existing 6x9 monospaced font with the compact Lucasfont Alternate via U8g2TextStyle (adjusting the text baseline), and adds the u8g2-fonts dependency. Entity relationship diagram for font dependency updateerDiagram
    MAIN_RS ||--o{ U8G2_FONTS : uses
    U8G2_FONTS {
        string u8g2_font_lucasfont_alternate_tf
    }
    MAIN_RS {
        string font
        string text_style
    }
Class diagram for font rendering update in main.rsclassDiagram
    class Text {
        +new(text: &str, position: Point, style: impl TextStyle)
    }
    class MonoTextStyle {
        +new(font: Font, color: BinaryColor)
    }
    class U8g2TextStyle {
        +new(font: U8g2Font, color: BinaryColor)
    }
    class FONT_6X9
    class u8g2_font_lucasfont_alternate_tf
    MonoTextStyle --|> TextStyle
    U8g2TextStyle --|> TextStyle
    FONT_6X9 <|-- MonoTextStyle
    u8g2_font_lucasfont_alternate_tf <|-- U8g2TextStyle
    Text o-- TextStyle
    %% Highlight the change: MonoTextStyle replaced by U8g2TextStyle, FONT_6X9 replaced by u8g2_font_lucasfont_alternate_tf
File-Level Changes
 Tips and commandsInteracting with Sourcery
 Customizing Your ExperienceAccess your dashboard to: 
 Getting Help
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
To use the available space on the bade more efficient, I changed the font to u8g2_font_lucasfont_alternate_tf from
u8g2-fonts.
Lucasfont Alternate was created by Patrick Lauke and is licensed under CC BY 3.0. No changes to the font were made.
Summary by Sourcery
Switch default font to Lucasfont Alternate for improved screen space usage, update text rendering position, and include the u8g2-fonts dependency.
New Features:
Enhancements:
Build: