-
Notifications
You must be signed in to change notification settings - Fork 540
Updated and fixed opentelemetry input plugin options configuration table. Fixes #2152. #2153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ble. Fixes fluent#2152. Signed-off-by: Eric D. Schabell <eric@schabell.org>
Signed-off-by: Eric D. Schabell <eric@schabell.org>
Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
@alexakreizinger or @esmerel please review, fixed extra back tick that was breaking the code examples and updated options configuration table to be complete with latest version. |
Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
Fun with Linting issues... |
alexakreizinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few suggestions, but LGTM :)
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
Warning Rate limit exceeded@eschabell has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 21 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe OpenTelemetry input plugin documentation was expanded: the configuration table now lists many additional public keys (networking, TLS, threading, buffering, storage, logging, and transport options), default values, reorganized sections, and added endpoint/transport examples. No code or runtime behavior was changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
♻️ Duplicate comments (2)
pipeline/inputs/opentelemetry.md (2)
23-23: Incorrect plugin type in log_supress_interval description.Line 23 references "output plugin" but this is an INPUT plugin, similar to the issue on line 22. This should reference "this plugin" or "the plugin" for consistency and accuracy.
Apply this diff:
-| `log_supress_interval` | Suppresses log messages from output plugin that appear similar within a specified time interval. `0` no suppression. | `0` | +| `log_supress_interval` | Suppresses log messages from this plugin that appear similar within a specified time interval. `0` no suppression. | `0` |Note: This aligns with @alexakreizinger's previous suggestion.
22-22: Incorrect plugin type in log_level description.Line 22 references "output plugin" but this is an INPUT plugin. This appears to be a copy-paste error from another plugin's documentation. The description should specify "this plugin" or "the plugin" to be accurate for an input context.
Apply this diff:
-| `log_level` | Specifies the log level for output plugin. If not set here, plugin uses global log level in `service` section. | `info` | +| `log_level` | Specifies the log level for this plugin. If not set here, the plugin uses the global log level specified in the `service` section of your configuration file. | `info` |Note: This aligns with @alexakreizinger's previous suggestion.
Applying review suggestion. Co-authored-by: Alexa Kreizinger <alexakreizinger@gmail.com> Signed-off-by: Eric D. Schabell <eric@schabell.org>
Applying review suggestion. Co-authored-by: Alexa Kreizinger <alexakreizinger@gmail.com> Signed-off-by: Eric D. Schabell <eric@schabell.org>
Applying review suggestion. Co-authored-by: Alexa Kreizinger <alexakreizinger@gmail.com> Signed-off-by: Eric D. Schabell <eric@schabell.org>
Applying review suggestion. Co-authored-by: Alexa Kreizinger <alexakreizinger@gmail.com> Signed-off-by: Eric D. Schabell <eric@schabell.org>
Applying review suggestion. Co-authored-by: Alexa Kreizinger <alexakreizinger@gmail.com> Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
All review comments processed and ai suggestions applied, merging. |
Updated and fixed opentelemetry input plugin options configuration table. Fixes #2152.
Summary by CodeRabbit