-
Notifications
You must be signed in to change notification settings - Fork 201
New Crowdin updates #1699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
New Crowdin updates #1699
Conversation
Summary of ChangesHello @extesy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取請求旨在透過更新和改進應用程式的繁體中文本地化內容,提升使用者體驗。這些變更涵蓋了從使用者介面訊息到詳細選項描述的各個方面,確保繁體中文使用者能夠更流暢、更準確地理解和使用應用程式。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Traditional Chinese (zh_TW) localization files. The changes are mostly good, improving consistency and correcting translations from Simplified to Traditional Chinese. However, I've found a few issues, including a missing translation for an FAQ question and an incorrect translation that confuses "window" with "tab". I've also pointed out some minor inconsistencies and awkward phrasing. Please review the detailed comments for suggestions.
| }, | ||
| "optFAQ_Q3": { | ||
| "message": "I need HoverZoom+ to be active for some sites only.", | ||
| "message": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This translation key is empty, but the English version has content: "I need HoverZoom+ to be active for some sites only.". This appears to be an accidental deletion and will result in a missing FAQ question in the UI. Please restore the translation. A possible translation is "我只希望 HoverZoom+ 在某些網站上啟用。".
| "message": "", | |
| "message": "我只希望 HoverZoom+ 在某些網站上啟用。", |
| }, | ||
| "optOpenImageInWindowKeyTitle": { | ||
| "message": "Open image in a new window", | ||
| "message": "在新分頁中開啟圖片", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| }, | ||
| "optZoomFactorUnitName": { | ||
| "message": "times", | ||
| "message": "次", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| }, | ||
| "optVideoPositionStep": { | ||
| "message": "Use prev/next action keys (or mousewheel) to change video position by", | ||
| "message": "使用後退/前進動作鍵(或滑鼠滑輪),調整影片位置前後", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current phrasing "調整影片位置前後" (adjust video position front/back) is a bit awkward. A more natural translation for "change video position by" would be "調整影片播放位置:", which clearly labels the subsequent input field for the step amount.
| "message": "使用後退/前進動作鍵(或滑鼠滑輪),調整影片位置前後", | |
| "message": "使用後退/前進動作鍵(或滑鼠滑輪)調整影片播放位置:", |
| }, | ||
| "optImagePaddingSize": { | ||
| "message": "Image padding size:", | ||
| "message": "圖片填充大小:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| }, | ||
| "optSaveImageKeyDescription": { | ||
| "message": "Press this key to save the image or video you are currently viewing. (Requires 'Enable saving media with action key' to be checked)", | ||
| "message": "按下此鍵可儲存目前正在檢視的圖片或視訊。(需要勾選「啟用動作鍵儲存媒體」)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of inconsistencies in this translation:
- The translation for the referenced option 'Enable saving media with action key' is inconsistent. Here it is "啟用動作鍵儲存媒體", but the option itself (
optAllowMediaSaving) is translated as "允許使用快捷鍵儲存媒體". Please use the same phrasing as the option label for consistency. - The word for "video" is "視訊" here, but "影片" is used in most other places (e.g.,
optZoomVideos). "影片" is more common in Traditional Chinese (Taiwan). Please use it consistently.
| "message": "按下此鍵可儲存目前正在檢視的圖片或視訊。(需要勾選「啟用動作鍵儲存媒體」)", | |
| "message": "按下此鍵可儲存目前正在檢視的圖片或影片。(需要勾選「允許使用快捷鍵儲存媒體」)", |
No description provided.