refactor: remove obsolete // +build tag #4307
Closed
+0
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vastonus <vastonus@outlook.com>
|
This breaks the build. Support for Go 1.13 is deliberate so people can build esbuild themselves for old OS versions. |
|
I'm closing this PR as it breaks the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Go 1.17, the preferred syntax for build constraints is
//go:build,which replaces the old
// +buildform. The old style is now considereddeprecated but still supported for backward compatibility.
This change removes the obsolete
// +build xxxline, keeping only themodern
//go:build xxxdirective.More info: golang/go#41184 and https://go.dev/doc/go1.17#build-lines
Design Doc / Proposal：
https://go.dev/design/draft-gobuild