fix: windows replace access denied error to EPERM #4067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voudin
force-pushed
the
fix/access_denied_windows
branch
2 times, most recently
from
edabb77 to
703bada
Compare
voudin
force-pushed
the
fix/access_denied_windows
branch
4 times, most recently
from
dc69acb to
f384d19
Compare
|
@evanw, Would it be possible to review this PR when you have a chance? |
fix evanw#3783 evanw#4017 On Windows, accessing a folder without read permissions results in an "access denied" error instead of EPERM. To ensure consistency across platforms, this error is now replaced with EPERM.
voudin
force-pushed
the
fix/access_denied_windows
branch
from
f384d19 to
be4f880
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3783 #4017
On Windows, accessing a folder without read permissions results in an "access denied" error instead of EPERM.
To ensure consistency across platforms, this error is now replaced with EPERM.
In restricted environments, users may not have permission to read the root folder of the disk.
