Skip to content

Conversation

@nwnt
Copy link
Member

@nwnt nwnt commented Oct 29, 2025

I'm removing CFG_NODE_COUNT where it's no longer needed, especially those passed as a flag during the build time. The flag is now only needed for selecting which docker compose file to use (either cluster of 1 or 3 nodes).

Also ran the following targets and confirmed they were successful:

  • make antithesis-build-etcd-image
  • make antithesis-build-client-docker-image
  • make antithesis-docker-compose-up
  • make antithesis-run-container-traffic
  • make antithesis-run-container-validation

@k8s-ci-robot k8s-ci-robot added area/testing github_actions Pull requests that update GitHub Actions code size/M labels Oct 29, 2025
@nwnt nwnt force-pushed the clean-up-cfg-nodecount branch from 628142a to ea970f2 Compare October 29, 2025 03:14
Signed-off-by: Nont <nont@duck.com>
@nwnt nwnt force-pushed the clean-up-cfg-nodecount branch from ea970f2 to 16d6ff7 Compare October 29, 2025 03:16
@k8s-ci-robot
Copy link

@nwnt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-integration-2-cpu-arm64 16d6ff7 link true /test pull-etcd-integration-2-cpu-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.22%. Comparing base (855c9ba) to head (16d6ff7).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20868      +/-   ##
==========================================
+ Coverage   69.19%   69.22%   +0.03%     
==========================================
  Files         422      422              
  Lines       34822    34822              
==========================================
+ Hits        24095    24106      +11     
+ Misses       9331     9322       -9     
+ Partials     1396     1394       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855c9ba...16d6ff7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nwnt
Copy link
Member Author

nwnt commented Oct 29, 2025

forgot to cc @serathius @joshjms

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nwnt, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit 87965e4 into etcd-io:main Oct 30, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/testing github_actions Pull requests that update GitHub Actions code size/M

Development

Successfully merging this pull request may close these issues.

3 participants