-
Notifications
You must be signed in to change notification settings - Fork 7.8k
feat(sd_mmc) Make UHS-I SDR the default for ESP-P4 SD_MMC #12038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello lbernstone, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Test Results 76 files 76 suites 15m 47s ⏱️ Results for commit b333d4c. ♻️ This comment has been updated with latest results. |
|
Please add a check for IDF versions greater than 5.3: https://github.com/espressif/arduino-esp32/actions/runs/19442524813/job/55629051409?pr=12038 |
c38ee43 to
b333d4c
Compare
Description of Change
SD_MMC driver had been updated to support UHS-I on ESP-P4, but didn't have the flags quite right. This updates the driver to use UHS SDR by default.
Test Scenarios
ESP32-P4-EYE reading a file off SD card. Speed is improved about 300%.
Related links
Should close #12027