-
Notifications
You must be signed in to change notification settings - Fork 7.8k
feat(core): Add option to support chip variants #12036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello me-no-dev, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
* add `chip_variant` to pioarduino-build.py to support different variants of an MCU (p4 prev3 and postv3) * Refactor build_mcu and chip_variant assignment logic * ci(pre-commit): Apply automatic fixes * Fix chip_variant retrieval with default value --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
|
@P-R-O-C-H-Y also removed the CPU freq selection menu, because it makes no sense anymore |
P-R-O-C-H-Y
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request introduces support for selecting and building against different ESP32P4 chip variants, improving flexibility for board configuration and toolchain compatibility. The changes primarily add a new "Chip Variant" menu option, update build variables to use the selected chip variant, and ensure the correct SDK paths are used during compilation.
Board configuration enhancements:
Chip Variantmenu option inboards.txtto allow users to select between different chip variants for ESP32P4 boards.prev3andpostv3) for ESP32P4, with corresponding build flags and CPU frequencies.Build system updates:
esp32p4.build.chip_variantvariable inboards.txtfor more precise board configuration.platform.txtto use{build.chip_variant}instead of{build.mcu}for SDK paths, ensuring the correct libraries are used for each variant.build.chip_variant={build.mcu}toplatform.txtto propagate the chip variant setting through the build process.Depends on espressif/esp32-arduino-lib-builder#333