Skip to content

Conversation

@Hannes-Beckmann
Copy link

Description of Change

This pull request introduces a new Zigbee Temperature Dimmable Light endpoint.

Test Scenarios

I have tested this Pull Request with pioarduino with the esp32-c6-devkitm-1 board on an ESP32-C6-MINI-1U using the ZHA-Integration in Home Assistant.
The included example is not tested since I do not have access to a board with a built-in RGB-LED.

Screenshot 2025-11-15 125912 Screenshot 2025-11-15 125927

Note that the minimum and maximum temperature is not respected by Home Assistant. Out of range values are clamped.

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Add Temperature Dimmable Light":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add documentation":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add example":
    • summary looks empty
    • type/action looks empty
  • the commit message "Apply requested changes":
    • summary looks empty
    • type/action looks empty
  • the commit message "Test to use the right Core":
    • summary looks empty
    • type/action looks empty
  • the commit message "Undo test":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello Hannes-Beckmann, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 19a539d

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Hannes-Beckmann, thank you for your addition to the Zigbee Library.
I have tested using a HA (ZHA) and a C6 with RGB light and it works as a charm.

I have requested a few changes to make the API as close to the other Light endpoints.

@P-R-O-C-H-Y P-R-O-C-H-Y added Area: Zigbee Issues and Feature Request about Zigbee Status: Awaiting Response Awaiting a response from the author labels Nov 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Test Results

 76 files   76 suites   18m 15s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 19a539d.

♻️ This comment has been updated with latest results.

@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented Nov 18, 2025

@Hannes-Beckmann What do tou think about extending the ColorDimmableLight with the Temperature color mode, as the light can support both, X/Y or Hue/SAT + Temp? #11654

@Hannes-Beckmann
Copy link
Author

Hi, good to hear that the example works as intended.
I think that that would be a good idea in principle, but I do not know how ZHA or HA would decide if a Light supports Temperature or not. My guess is that an extra endpoint would be needed which combines the ColorDimmableLight and the TemperatureDimmableLight. I am working on a Zigbee dimmer for a RGBCCT LED-Strip, so maybe I will open a pull request in the future.

@github-actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5000.000.00000.000.00
ESP32S30⚠️ +3080.00⚠️ +0.05000.000.00
ESP32S20⚠️ +3080.00⚠️ +0.05000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP320⚠️ +3080.00⚠️ +0.05000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/Zigbee/examples/Zigbee_Analog_Input_Output00⚠️ +3080⚠️ +3080000000⚠️ +3080
libraries/Zigbee/examples/Zigbee_Binary_Input_Output00------0000--
libraries/Zigbee/examples/Zigbee_CarbonDioxide_Sensor00------0000--
libraries/Zigbee/examples/Zigbee_Color_Dimmable_Light00------0000--
libraries/Zigbee/examples/Zigbee_Color_Dimmer_Switch00⚠️ +3080⚠️ +3080000000⚠️ +3080
libraries/Zigbee/examples/Zigbee_Contact_Switch00------0000--
libraries/Zigbee/examples/Zigbee_Dimmable_Light00------0000--
libraries/Zigbee/examples/Zigbee_Electrical_AC_Sensor00⚠️ +3080⚠️ +3080000000⚠️ +3080
libraries/Zigbee/examples/Zigbee_Electrical_AC_Sensor_MultiPhase00⚠️ +3080⚠️ +3080000000⚠️ +3080
libraries/Zigbee/examples/Zigbee_Electrical_DC_Sensor00------0000--
libraries/Zigbee/examples/Zigbee_Fan_Control00⚠️ +3080⚠️ +3080000000⚠️ +3080
libraries/Zigbee/examples/Zigbee_Gateway00⚠️ +3080⚠️ +308000----⚠️ +3080
libraries/Zigbee/examples/Zigbee_Illuminance_Sensor00------0000--
libraries/Zigbee/examples/Zigbee_Multistate_Input_Output00⚠️ +3080⚠️ +3080000000⚠️ +3080
libraries/Zigbee/examples/Zigbee_OTA_Client00------0000--
libraries/Zigbee/examples/Zigbee_Occupancy_Sensor00------0000--
libraries/Zigbee/examples/Zigbee_On_Off_Light00------0000--
libraries/Zigbee/examples/Zigbee_On_Off_MultiSwitch00⚠️ +3080⚠️ +3080000000⚠️ +3080
libraries/Zigbee/examples/Zigbee_On_Off_Switch00⚠️ +3080⚠️ +3080000000⚠️ +3080
libraries/Zigbee/examples/Zigbee_PM25_Sensor00------0000--
libraries/Zigbee/examples/Zigbee_Power_Outlet00⚠️ +3080⚠️ +3080000000⚠️ +3080
libraries/Zigbee/examples/Zigbee_Pressure_Flow_Sensor00------0000--
libraries/Zigbee/examples/Zigbee_Range_Extender00⚠️ +3080⚠️ +3080000000⚠️ +3080
libraries/Zigbee/examples/Zigbee_Scan_Networks00------0000--
libraries/Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy00------0000--
libraries/Zigbee/examples/Zigbee_Temperature_Dimmable_Light--------------
libraries/Zigbee/examples/Zigbee_Temperature_Sensor00------0000--
libraries/Zigbee/examples/Zigbee_Thermostat00⚠️ +3080⚠️ +3080000000⚠️ +3080
libraries/Zigbee/examples/Zigbee_Vibration_Sensor00------0000--
libraries/Zigbee/examples/Zigbee_Wind_Speed_Sensor00------0000--

@P-R-O-C-H-Y
Copy link
Member

Hi @Hannes-Beckmann, If that are 2 endpoints, then it will how up as 2 lights. Not a single light with both options.
I will test it together in 1 endpoint and if that works out, may I update your PR to just add this feature to existing ColorDimmableLight or will you want to do that yourself.

@Hannes-Beckmann
Copy link
Author

I think we might have misunderstood each other earlier.
When I say endpoint, I’m referring to classes inside Zigbee/src/ep, not a separate Zigbee endpoint on the device.

If temperature support is added directly into ColorDimmableLight, Home Assistant will likely always show a temperature slider, even for users who only want to control an RGB LED strip without any white LEDs. Because of that, I think different classes to match different hardware configurations would be needed. Something like:

  • DimmableLight - single-channel lights (already implemented)
  • TemperatureDimmableLight - dual-channel warm/cold white lights (this PR)
  • ColorDimmableLight - RGB lights (already implemented)
  • ColorWhiteDimmableLight - RGBWW or RGBCW lights with four channels (not sure if Zigbee supports this)
  • ColorTemperatureDimmableLight - RGBCCT lights with five channels (which I think is what you were proposing)

Of course, users could emulate missing white channels through some calculations on RGB lights, but that shouldn't affect how these endpoint classes are designed.

If a ColorTemperatureDimmableLight is what you are proposing, I would offer to write a PR for that, since I am working on a project that could use this, but this will take some time.

@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented Nov 19, 2025

The zippy is actually reading the color_capabilities attribute which should be used later on to show the proper controls - https://github.com/zigpy/zha/blob/7ca9e13db07bd7dff9b0017de3ef58cf993b9430/zha/zigbee/cluster_handlers/lighting.py#L54-L155
I will test if using different color_capabilitues will be showing the proper controls.

I mean that in the ColorDimambleLight, there will be a new method (or set of methods) to specify the color modes or add them 1 by one. I will do some tests and reach back to you.

I think that having all those Light classes is just multiplication of something, that can be easily contained in 1 class.

@Hannes-Beckmann
Copy link
Author

Ahh okay, if that is the case, enabling features would be a much cleaner alternative than duplicating everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Zigbee Issues and Feature Request about Zigbee Status: Awaiting Response Awaiting a response from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants