Postcss #7
Postcss #7
Conversation
ryanbethel
left a comment
ryanbethel
left a comment
There was a problem hiding this comment.
This looks good. Glad we can finally support new css features as soon as they land.
In order to support compiling this to WASM I think we will have to vendor the prettify package eventually. It uses node APIs (fs and path) that are not available for WASM.
|
OK I forked and fixed the existing postcss-prettify here: Will update this PR to use the fixed version |
|
OK @ryanbethel I updated to an external postcss shady-selectors plugin and forked prettify to remove unused deps that were breaking WASM compilation. Can you give this another whirl and see if it satisfies the requirements please? |
ryanbethel
left a comment
ryanbethel
left a comment
There was a problem hiding this comment.
I think the PR is great. Code changes look good. When trying to compile to wasm I had a new issue. The wasm now compiles so that problem is fixed. But the binary goes from 4meg to 13meg. Not sure if that is a problem. The bigger problem is that it does not work. I suspect some async function, but I will have to dig in a bit more to find out.
|
Bummer. |
Swaps out css with postcss due to lack of support.
Adds CSS nesting selectors.