Skip to content

Remove test dependency on unmaintained PyPI toml package #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

Remove test dependency on unmaintained PyPI toml package #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion requirements-test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@ build
coverage
pytest
pytest-rerunfailures
toml
# Some tests need to write TOML, but tomli and tomllib are read-only, and toml package is unmaintained
tomli-w
wheel
4 changes: 2 additions & 2 deletions tests/lib/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from secrets import token_hex
from typing import Any, Callable

import toml
import tomli_w

log = logging.getLogger(__name__)
root = Path(__file__).parent.parent
Expand Down Expand Up @@ -217,7 +217,7 @@ def create_pyproject_toml(
if config != NotImplemented:
cfg["tool"] = {"setuptools-git-versioning": config}

return create_file(cwd, "pyproject.toml", toml.dumps(cfg), commit=commit, **kwargs)
return create_file(cwd, "pyproject.toml", tomli_w.dumps(cfg), commit=commit, **kwargs)


def create_setup_py(
Expand Down
4 changes: 2 additions & 2 deletions tests/test_integration/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import textwrap

import pytest
import toml
import tomli_w

from tests.lib.util import (
create_file,
Expand Down Expand Up @@ -66,7 +66,7 @@ def test_config_not_used(repo):
create_file(
repo,
"pyproject.toml",
toml.dumps(cfg),
tomli_w.dumps(cfg),
)

assert get_version(repo, isolated=False) == "0.0.0"
Expand Down
Loading