- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5.8k
feature: support customized sidebar item name from content #1825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            Jacco-V
  wants to merge
  17
  commits into
  docsifyjs:develop
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
Jacco-V:feature-customizableSidebarItemName
  
      
      
   
  
    
  
  
  
 
  
      
    base: develop
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from 1 commit
      Commits
    
    
            Show all changes
          
          
            17 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      eb5f939
              
                Implement support for setting a customized sidebar item name from the…
              
              
                 a764b02
              
                Push both title and label to toc (=table of contents) array
              
              
                 cfca427
              
                Apply changes to duplicate code block
              
              
                 cdca395
              
                Apply new functionality to doc file
              
              
                 f536e72
              
                Refactor for better readability
              
              
                 e581df7
              
                Support quoted strings for config value arguments
              
              
                 27513e0
              
                Update render-util tests
              
              
                 cf9e00b
              
                replace function chaining with more modified regex
              
              
                 83e5795
              
                replace 'label' with 'text' for more intuitive variable naming
              
              
                 b838fc3
              
                Fix incorrect (escaped) quoted string parsing
              
              
                 da7937e
              
                Fix logic for html-escaped str argument
              
              
                 d66d22d
              
                Fix test arguments to match reality
              
              
                 71288be
              
                Change test to provide html-escaped string
              
              
                 79e738a
              
                Change regex to work directly on html-escaped string
              
              
                 a6333ec
              
                Add support for marked.md `smartypants` 'smart' quotes
              
              
                 5a1e655
              
                Merge branch 'develop' into feature-customizableSidebarItemName
              
              
                Koooooo-7 03fda8b
              
                Merge branch 'develop' into feature-customizableSidebarItemName
              
              
                jhildenbiddle File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried the patch, but looking at this I would think that the sidebar text would also be used in the rendered page, but I don't think this is correct. We want the sidebar text in the sidebar but not in the page.
Have you tried this? :-)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I have not tried the changes, because I do not have a working frontend development environment. (I'm just a backend dev giving this a try).
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, where can I find the automated tests for this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create a _sidebar.md https://docsify.js.org/#/more-pages?id=sidebar