Drop blaze #1995
Draft
Drop blaze #1995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the idea that since we only support |
|
Yep, and with the simple implementation GHC can optimize hsx expressions better. This results in less memory usage and faster runtime performance (we should do a benchmark to figure out how significant the difference is). Ideally we switch from Text to https://hackage.haskell.org/package/mason which provides even faster string concatenation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch implement HSX without blaze. In theory HSX can be optimized a lot further because blaze has a lot of indirection in it's data structures (e.g. to support multiple string types).