Skip to content

Conversation

@sebst
Copy link
Member

@sebst sebst commented Oct 30, 2025

Closes #65

@sebst sebst linked an issue Oct 30, 2025 that may be closed by this pull request
@sebst sebst requested a review from Copilot October 30, 2025 08:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for installing the charmbracelet/gum CLI tool as a devcontainer feature. It follows the established pattern in this repository for adding new features.

  • Implements a new devcontainer feature for the gum binary from Charmbracelet
  • Uses GitHub releases to download and install the appropriate binary for the system architecture
  • Includes automated testing to verify the installation

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/charmbracelet-gum/devcontainer-feature.json Defines the feature metadata with configurable version option
src/charmbracelet-gum/install.sh Installation script that downloads and installs gum binary from GitHub releases
test/charmbracelet-gum/test.sh Test script to verify gum is installed and functional
.github/workflows/test.yaml Adds charmbracelet-gum to the CI test matrix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +86 to +90
# if [[ "$arch" == "aarch64" ]]; then
# arch="arm64"
# elif [[ "$arch" == "x86_64" ]]; then
# arch="x64"
# fi
Copy link

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented-out code for architecture mapping should be removed or implemented. The current implementation returns uname -m output directly (e.g., 'x86_64', 'aarch64'), which must match the naming convention used in the gum release archives. If the releases use different architecture names, this mapping logic should be uncommented and corrected.

Suggested change
# if [[ "$arch" == "aarch64" ]]; then
# arch="arm64"
# elif [[ "$arch" == "x86_64" ]]; then
# arch="x64"
# fi
if [[ "$arch" == "aarch64" ]]; then
arch="arm64"
elif [[ "$arch" == "x86_64" ]]; then
arch="x64"
fi

Copilot uses AI. Check for mistakes.
# arch="x64"
# fi
echo "$arch"
# echo "$(dpkg --print-architecture)" --- IGNORE ---
Copy link

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commented-out line with '--- IGNORE ---' should be removed as it serves no purpose and clutters the code.

Suggested change
# echo "$(dpkg --print-architecture)" --- IGNORE ---

Copilot uses AI. Check for mistakes.
@sebst sebst marked this pull request as ready for review October 30, 2025 08:34
@sebst sebst merged commit 51bc783 into main Oct 30, 2025
74 checks passed
@sebst sebst deleted the 65-add-gum branch October 30, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add gum

2 participants