refs #424 / fixes #589 - do not store reference to filelist in simplecpp::Location / added simplecpp::TokenList::file() / cleanups
#573
Conversation
|
CC @glankk |
|
This affects the implementation in Cppcheck. Still working on integrating it. |
|
|
||
| Location &operator=(const Location &other) { | ||
| if (this != &other) { | ||
| fileIndex = other.fileIndex; | ||
| line = other.line; | ||
| col = other.col; | ||
| } | ||
| return *this; | ||
| } | ||
| Location &operator=(const Location &other) = default; |
There was a problem hiding this comment.
This was lacking the assignment of files. I have no idea how that could have ever been a valid object - beside the fact that containing a reference is even problematic to begin with.
firewave
force-pushed
the
toklist-files-3
branch
from
ee3d11c to
29156d6
Compare
|
Should not be merged before we post a release with the MinGW fixes. I also want to get in some preprocessor cleanups on the Cppcheck side first. |
…ocation` / cleanups
…e from location
firewave
force-pushed
the
toklist-files-3
branch
from
29156d6 to
dac4823
Compare
firewave
changed the title
simplecpp::Location / added simplecpp::TokenList::file() / cleanupssimplecpp::Location / added simplecpp::TokenList::file() / cleanups
|
if this fixes a crash in cppcheck I am pretty interested to get this in. what do you think must happen before we can merge this PR ? It is still in a draft state. |
|
To land this downstream it requires changes to the Cppcheck code which I still haven't finished locally as I keep running into issues, low quality code and missing test coverage. That is what all the preprocessor fixing and refactoring is all about. I am not sure how long it will take since I am not sure on how to fix everything along the way yet. But it might be that this crash will become latent by one of the downstream fixes. I have not verified that yet. |
2 participants
No description provided.