feat(images): change preview image on post and home page based on lig… #2566
+104
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ht/dark mode, scaling This PR adds the ability to change the image seen by the user for the post preview on the home page and on the page if set in the YAML front matter. Closes Post image and homepage card color change by theme change Fixes cotes2020#2554
|
Test suite failing to find the image on the CDN path defined in |
|
Why not keep it simple, just swap the image without adding more in-line CSS? |
Signed-off-by: Natalie Somersall <natalie.somersall@gmail.com>
Signed-off-by: Natalie Somersall <natalie.somersall@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change preview image on post and home page based on light/dark mode, scaling
Type of change
Description
This PR adds the ability to change the image seen by the user for the post preview on the home page and on the page if set in the YAML front matter.
Additional context
Closes Post image and homepage card color change by theme change Fixes #2554