Skip to content

feat(ics-033): optimize client updates in multi-hop protocol #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(ics-033): optimize client updates in multi-hop protocol #1213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions spec/core/ics-033-multi-hop/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,10 @@ func (Chain) QueryStateAtHeight(key string, height int64) (value []byte, proof [
// UpdateClient updates the client state corresponding to the next chain in the channel path
func (*Chain) UpdateClient()

// UpdateClientToHeight updates the client state corresponding to the next chain in the channel path
// to a specific height rather than the latest height
func (*Chain) UpdateClientToHeight(height exported.Height)

// ProofHeights contains multi-hop proof query height data.
type ProofHeights struct {
proofHeight exported.Height // query the proof at this height
Expand Down Expand Up @@ -204,12 +208,16 @@ func calcProofHeights(

// if no suitable consensusHeight then update client and use latest chain height/client height
//
// TODO: It could be more efficient to update the client with the missing block height
// rather than the latest block height since it would be less likely to need client updates
// on subsequent chains.
if height.proofHeight == nil {
abortTransactionUnless(chain.UpdateClient())
height.proofHeight = chain.GetLatestHeight()
// Update the client with the specific missing block height if available,
// otherwise fall back to updating with the latest block height
if consensusHeight != nil {
abortTransactionUnless(chain.UpdateClientToHeight(consensusHeight))
height.proofHeight = consensusHeight
} else {
abortTransactionUnless(chain.UpdateClient())
height.proofHeight = chain.GetLatestHeight()
}
height.consensusHeight = chain.GetClientStateHeight(chains[chainIdx+1])
}

Expand Down