Skip to content

refactor(ScmProvider): replace sorted with max #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

refactor(ScmProvider): replace sorted with max #1543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions commitizen/providers/scm_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,8 @@ def get_version(self) -> str:
rules = TagRules.from_settings(self.config.settings)
tags = get_tags(reachable_only=True)
version_tags = rules.get_version_tags(tags)
versions = sorted(rules.extract_version(t) for t in version_tags)
if not versions:
return "0.0.0"
return str(versions[-1])
version = max((rules.extract_version(t) for t in version_tags), default=None)
return str(version) if version is not None else "0.0.0"

def set_version(self, version: str) -> None:
# Not necessary
Expand Down