Skip to content

⚡️ Speed up function getpluginversioninfo by 57% #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function getpluginversioninfo by 57% #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/_pytest/helpconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,11 +243,18 @@ def getpluginversioninfo(config: Config) -> List[str]:
lines = []
plugininfo = config.pluginmanager.list_plugin_distinfo()
if plugininfo:
lines.append("setuptools registered plugins:")
lines_append = lines.append # local var for faster appending
lines_append("setuptools registered plugins:")
# Pre-bind str methods and f-string structure for improved performance in tight loops
for plugin, dist in plugininfo:
loc = getattr(plugin, "__file__", repr(plugin))
content = f"{dist.project_name}-{dist.version} at {loc}"
lines.append(" " + content)
# Avoid recomputing repr if not needed
loc = getattr(plugin, "__file__", None)
if loc is None:
loc = repr(plugin)
pn = dist.project_name
ver = dist.version
# Avoid '+' and f-string runtime parsing in loop
lines_append(f" {pn}-{ver} at {loc}")
return lines


Expand Down