Skip to content

Support latest Temporal proposal #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support latest Temporal proposal #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,9 +259,6 @@ function extensiveDeepEqualByType(leftHandOperand, rightHandOperand, leftHandTyp
return leftHandOperand.equals(rightHandOperand);
case 'Temporal.Duration':
return leftHandOperand.total('nanoseconds') === rightHandOperand.total('nanoseconds');
case 'Temporal.TimeZone':
case 'Temporal.Calendar':
return leftHandOperand.toString() === rightHandOperand.toString();
default:
return objectEqual(leftHandOperand, rightHandOperand, options);
}
Expand Down
17 changes: 5 additions & 12 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
}
},
"devDependencies": {
"@js-temporal/polyfill": "^0.4.3",
"@js-temporal/polyfill": "^0.5.1",
"@rollup/plugin-commonjs": "^24.1.0",
"@web/test-runner": "^0.16.1",
"benchmark": "^2.1.0",
Expand Down
24 changes: 0 additions & 24 deletions test/temporal-types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,28 +106,4 @@ describe('TC39 Temporal', function () {
'eql(new Temporal.Duration(0, 0, 0, 1), new Temporal.Duration(0, 0, 0, 2)) === false');
});
});

describe('Temporal.TimeZone', function () {
it('returns true for same time zones', function () {
assert(eql(new Temporal.TimeZone('+01:00'), new Temporal.TimeZone('+01:00')),
'eql(new Temporal.TimeZone("+01:00"), new Temporal.TimeZone("+01:00"))');
});

it('returns false for different time zones', function () {
assert(eql(new Temporal.TimeZone('+01:00'), new Temporal.TimeZone('+02:00')) === false,
'eql(new Temporal.TimeZone("+01:00"), new Temporal.TimeZone("+02:00")) === false');
});
});

describe('Temporal.Calendar', function () {
it('returns true for same calendars', function () {
assert(eql(new Temporal.Calendar('gregory'), new Temporal.Calendar('gregory')),
'eql(new Temporal.Calendar("gregory"), new Temporal.Calendar("gregory"))');
});

it('returns false for different calendars', function () {
assert(eql(new Temporal.Calendar('gregory'), new Temporal.Calendar('iso8601')) === false,
'eql(new Temporal.Calendar("gregory"), new Temporal.Calendar("iso8601")) === false');
});
});
});