Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Aug 22, 2025

  • Fix bypass universal apps being blocked by "Block apps not in use" when device locked
  • Add bypass universal check to background blocking logic
  • Add bypass universal check to device lock blocking logic
  • Add unit tests documenting bypass universal behavior
  • Remove redundant bypass universal checks after reviewer feedback

Changes Made

Removed redundant bypass universal checks based on reviewer feedback:

  • The main bypass universal check at line 670 already handles apps with bypass status by returning early (RULE8/RULE9)
  • Apps with bypass universal never reach the device lock or background blocking logic
  • Removed the additional checks that were added in device lock and background blocking methods
  • This makes the code cleaner and avoids unnecessary duplication

The fix still addresses the original issue #2148 through the main bypass universal logic flow that was already present in the codebase.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 3 commits August 22, 2025 16:00
Co-authored-by: ignoramous <852289+ignoramous@users.noreply.github.com>
Co-authored-by: ignoramous <852289+ignoramous@users.noreply.github.com>
Co-authored-by: ignoramous <852289+ignoramous@users.noreply.github.com>
Copilot AI changed the title [WIP] v055t: Block apps not in use blocks bypassed apps Fix bypass universal apps being blocked by "Block apps not in use" when device locked Aug 22, 2025
Copilot AI requested a review from ignoramous August 22, 2025 16:06
Copilot finished work on behalf of ignoramous August 22, 2025 16:06
Copy link
Collaborator

@hussainmohd-a hussainmohd-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot appStatus.bypassDnsFirewall() is already taken care before handling all the universal firewall rules. No need to again have the check inside the blockBackgroundData() / deviceLocked() check.

…und blocking

Co-authored-by: hussainmohd-a <56958445+hussainmohd-a@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Aug 28, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from hussainmohd-a August 28, 2025 13:05
Copilot finished work on behalf of hussainmohd-a August 28, 2025 13:05
@hussainmohd-a hussainmohd-a marked this pull request as ready for review August 28, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants