-
-
Notifications
You must be signed in to change notification settings - Fork 220
Fix bypass universal apps being blocked by "Block apps not in use" when device locked #2149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: ignoramous <852289+ignoramous@users.noreply.github.com>
Co-authored-by: ignoramous <852289+ignoramous@users.noreply.github.com>
Co-authored-by: ignoramous <852289+ignoramous@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot appStatus.bypassDnsFirewall() is already taken care before handling all the universal firewall rules. No need to again have the check inside the blockBackgroundData() / deviceLocked() check.
app/src/main/java/com/celzero/bravedns/service/BraveVPNService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/celzero/bravedns/service/BraveVPNService.kt
Outdated
Show resolved
Hide resolved
…und blocking Co-authored-by: hussainmohd-a <56958445+hussainmohd-a@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Changes Made
Removed redundant bypass universal checks based on reviewer feedback:
The fix still addresses the original issue #2148 through the main bypass universal logic flow that was already present in the codebase.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.