Fix separate object store race condition #294
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoblerS
reviewed
Nov 12, 2025
KoblerS
reviewed
Nov 12, 2025
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Collaborator
|
will you align logging with the new approach using LOG? |
KoblerS
reviewed
Nov 13, 2025
Contributor
Author
I aligned it now in the services and would open another PR to align it in the remaining files |
KoblerS
requested changes
Nov 13, 2025
Collaborator
KoblerS
left a comment
KoblerS
left a comment
There was a problem hiding this comment.
I did not included all suggestions for all object store provider implementations of the createClient function but I think you'll get the point
KoblerS
reviewed
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using MTX + separate Object Store mode there is a chance for a race condition because the Object store bucket is stored as a property on the service which is however shared across all tenants.
The PR addresses this by introducing getBucket / getClient methods and within these the tenant-specific cache lookup is performed / a new client is created.