Limit the size of LruBitmapPool/MemoryCache when app is in background #5626
+90
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
When an app is moved to background, onTrimMemory() will be called, and LruBitmapPool/MemoryCache will be trimmed. However, the app could keep running and bitmaps will be retired to MemoryCache and LruBitmapPool. This change allows limit of the sizes of LruBitmapPool/MemoryCache (by MemoryCategory) when the app is in background, and restore the sizes to normal when it's moved out of background.
ericmiao
force-pushed
the
limit-cache-in-background
branch
from
4bf6d72 to
0c1d3e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an app is moved to background, onTrimMemory() will be called, and LruBitmapPool/MemoryCache will be trimmed. However, the app could keep running and bitmaps will be retired to MemoryCache and LruBitmapPool. In many cases, the amount of memory due to the retired bitmaps in cache is non-trivial.
This change allows an app to limit of the sizes of LruBitmapPool/MemoryCache (by MemoryCategory) when the app is in background, and restore the sizes to normal when it's moved out of background.