-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[Android] Apply tinting for Import/Export password manager icons #32099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Apply tinting for Import/Export password manager icons #32099
Conversation
|
The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "password" and so security team members have been added as reviewers to take a look. |
|
@aguscruiz @fallaciousreasoning - Would either of you mind giving the diff a quick check to see if the colours are as expected? If not, let me know what to change to. |
|
Looks ok to me, would you mind also posting a screenshot on how it looks when dynamic theming colors are enabled? |
|
Unrelated, I see the icons being used are from material design icons. The figma file has the correct icons to use.
|
@aguscruiz a rather trivial question: How would I configure this on a Google Pixel 10 device in order to test it? |
|
Enable chrome://brave-android-dynamic-colors and then change the OS theme 😄 |
This, and you'll notice the different parts of the browser will be tinted depending on your Android color themes |
|
resolved on Slack |
Previously, the import/export icons were not correctly tinted when the Android OS was set to dark mode. To correct this, the icons no longer use a hard-coded fill colour and an iconTint property is applied in order to leverage the built-in support that Chromium has for automatically adjusting icons for light/dark mode. The icons have also been replaced with the upload/download SVG paths from the brave/leo repo. Resolves brave/brave-browser#50232
14504f5 to
4372848
Compare
|
Released in v1.86.22 |
|
Verified on STEPS:
ACTUAL RESULTS:
|





Previously, the import/export icons were not correctly tinted when the Android OS was set to dark mode.
To correct this, the icons no longer use a hard-coded fill colour and an iconTint property is applied in order to leverage the built-in support that Chromium has for automatically adjusting icons for light/dark mode.
Resolves brave/brave-browser#50232